Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog.h

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_H_ 5 #ifndef CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_H_
6 #define CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_H_ 6 #define CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
11 #include "content/public/browser/javascript_dialog_manager.h" 11 #include "content/public/browser/javascript_dialog_manager.h"
12 12
13 class AppModalDialogHelper; 13 class AppModalDialogHelper;
14 14
15 class JavaScriptDialog { 15 class JavaScriptDialog {
16 public: 16 public:
17 virtual ~JavaScriptDialog(); 17 virtual ~JavaScriptDialog();
18 18
19 static base::WeakPtr<JavaScriptDialog> Create( 19 static base::WeakPtr<JavaScriptDialog> Create(
20 content::WebContents* parent_web_contents, 20 content::WebContents* parent_web_contents,
21 content::WebContents* alerting_web_contents, 21 content::WebContents* alerting_web_contents,
22 const base::string16& title, 22 const base::string16& title,
23 content::JavaScriptMessageType message_type, 23 content::JavaScriptDialogType dialog_type,
24 const base::string16& message_text, 24 const base::string16& message_text,
25 const base::string16& default_prompt_text, 25 const base::string16& default_prompt_text,
26 const content::JavaScriptDialogManager::DialogClosedCallback& 26 const content::JavaScriptDialogManager::DialogClosedCallback&
27 dialog_callback); 27 dialog_callback);
28 28
29 // Closes the dialog without sending a callback. This is useful when the 29 // Closes the dialog without sending a callback. This is useful when the
30 // JavaScriptDialogTabHelper needs to make this dialog go away so that it can 30 // JavaScriptDialogTabHelper needs to make this dialog go away so that it can
31 // respond to a call that requires it to make no callback or make a customized 31 // respond to a call that requires it to make no callback or make a customized
32 // one. 32 // one.
33 virtual void CloseDialogWithoutCallback() = 0; 33 virtual void CloseDialogWithoutCallback() = 0;
34 34
35 protected: 35 protected:
36 explicit JavaScriptDialog(content::WebContents* parent_web_contents); 36 explicit JavaScriptDialog(content::WebContents* parent_web_contents);
37 37
38 private: 38 private:
39 std::unique_ptr<AppModalDialogHelper> dialog_helper_; 39 std::unique_ptr<AppModalDialogHelper> dialog_helper_;
40 }; 40 };
41 41
42 #endif // CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_H_ 42 #endif // CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698