Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1963)

Unified Diff: components/app_modal/javascript_app_modal_dialog.h

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal/javascript_app_modal_dialog.h
diff --git a/components/app_modal/javascript_app_modal_dialog.h b/components/app_modal/javascript_app_modal_dialog.h
index 0fb4d899788fb1f1e598e72378ef3d54e1a8aaec..a87febde9fea56ea51c757ba00f38de1dc3ab8e9 100644
--- a/components/app_modal/javascript_app_modal_dialog.h
+++ b/components/app_modal/javascript_app_modal_dialog.h
@@ -40,7 +40,7 @@ class JavaScriptAppModalDialog : public AppModalDialog {
content::WebContents* web_contents,
ExtraDataMap* extra_data_map,
const base::string16& title,
- content::JavaScriptMessageType javascript_message_type,
+ content::JavaScriptDialogType javascript_dialog_type,
const base::string16& message_text,
const base::string16& default_prompt_text,
bool display_suppress_checkbox,
@@ -67,8 +67,8 @@ class JavaScriptAppModalDialog : public AppModalDialog {
void SetOverridePromptText(const base::string16& prompt_text);
// Accessors
- content::JavaScriptMessageType javascript_message_type() const {
- return javascript_message_type_;
+ content::JavaScriptDialogType javascript_dialog_type() const {
+ return javascript_dialog_type_;
}
base::string16 message_text() const { return message_text_; }
base::string16 default_prompt_text() const { return default_prompt_text_; }
@@ -89,7 +89,7 @@ class JavaScriptAppModalDialog : public AppModalDialog {
ExtraDataMap* extra_data_map_;
// Information about the message box is held in the following variables.
- const content::JavaScriptMessageType javascript_message_type_;
+ const content::JavaScriptDialogType javascript_dialog_type_;
base::string16 message_text_;
base::string16 default_prompt_text_;
bool display_suppress_checkbox_;
« no previous file with comments | « chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc ('k') | components/app_modal/javascript_app_modal_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698