Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1686)

Unified Diff: android_webview/browser/aw_javascript_dialog_manager.cc

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_javascript_dialog_manager.cc
diff --git a/android_webview/browser/aw_javascript_dialog_manager.cc b/android_webview/browser/aw_javascript_dialog_manager.cc
index 7e06ff45f094a90d362b360d7ec6c3e5239c8810..6b5338647befa47e8ca9a4d2e1f8f27774d8ef54 100644
--- a/android_webview/browser/aw_javascript_dialog_manager.cc
+++ b/android_webview/browser/aw_javascript_dialog_manager.cc
@@ -17,7 +17,7 @@ AwJavaScriptDialogManager::~AwJavaScriptDialogManager() {}
void AwJavaScriptDialogManager::RunJavaScriptDialog(
content::WebContents* web_contents,
const GURL& origin_url,
- content::JavaScriptMessageType message_type,
+ content::JavaScriptDialogType dialog_type,
const base::string16& message_text,
const base::string16& default_prompt_text,
const DialogClosedCallback& callback,
@@ -29,11 +29,8 @@ void AwJavaScriptDialogManager::RunJavaScriptDialog(
return;
}
- bridge->RunJavaScriptDialog(message_type,
- origin_url,
- message_text,
- default_prompt_text,
- callback);
+ bridge->RunJavaScriptDialog(dialog_type, origin_url, message_text,
+ default_prompt_text, callback);
}
void AwJavaScriptDialogManager::RunBeforeUnloadDialog(
« no previous file with comments | « android_webview/browser/aw_javascript_dialog_manager.h ('k') | android_webview/native/aw_contents_client_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698