Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/guest_view/web_view/javascript_dialog_helper.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/web_view/javascript_dialog_helper.h" 5 #include "extensions/browser/guest_view/web_view/javascript_dialog_helper.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "components/guest_view/common/guest_view_constants.h" 9 #include "components/guest_view/common/guest_view_constants.h"
10 #include "extensions/browser/guest_view/web_view/web_view_constants.h" 10 #include "extensions/browser/guest_view/web_view/web_view_constants.h"
11 #include "extensions/browser/guest_view/web_view/web_view_guest.h" 11 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
12 #include "extensions/browser/guest_view/web_view/web_view_permission_helper.h" 12 #include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"
13 #include "extensions/browser/guest_view/web_view/web_view_permission_types.h" 13 #include "extensions/browser/guest_view/web_view/web_view_permission_types.h"
14 14
15 namespace extensions { 15 namespace extensions {
16 16
17 namespace { 17 namespace {
18 18
19 std::string JavaScriptMessageTypeToString( 19 std::string JavaScriptDialogTypeToString(
20 content::JavaScriptMessageType message_type) { 20 content::JavaScriptDialogType dialog_type) {
21 switch (message_type) { 21 switch (dialog_type) {
22 case content::JAVASCRIPT_MESSAGE_TYPE_ALERT: 22 case content::JAVASCRIPT_DIALOG_TYPE_ALERT:
23 return "alert"; 23 return "alert";
24 case content::JAVASCRIPT_MESSAGE_TYPE_CONFIRM: 24 case content::JAVASCRIPT_DIALOG_TYPE_CONFIRM:
25 return "confirm"; 25 return "confirm";
26 case content::JAVASCRIPT_MESSAGE_TYPE_PROMPT: 26 case content::JAVASCRIPT_DIALOG_TYPE_PROMPT:
27 return "prompt"; 27 return "prompt";
28 default: 28 default:
29 NOTREACHED() << "Unknown JavaScript Message Type."; 29 NOTREACHED() << "Unknown JavaScript Message Type.";
30 return "unknown"; 30 return "unknown";
31 } 31 }
32 } 32 }
33 33
34 } // namespace 34 } // namespace
35 35
36 JavaScriptDialogHelper::JavaScriptDialogHelper(WebViewGuest* guest) 36 JavaScriptDialogHelper::JavaScriptDialogHelper(WebViewGuest* guest)
37 : web_view_guest_(guest) { 37 : web_view_guest_(guest) {
38 } 38 }
39 39
40 JavaScriptDialogHelper::~JavaScriptDialogHelper() { 40 JavaScriptDialogHelper::~JavaScriptDialogHelper() {
41 } 41 }
42 42
43 void JavaScriptDialogHelper::RunJavaScriptDialog( 43 void JavaScriptDialogHelper::RunJavaScriptDialog(
44 content::WebContents* web_contents, 44 content::WebContents* web_contents,
45 const GURL& origin_url, 45 const GURL& origin_url,
46 content::JavaScriptMessageType javascript_message_type, 46 content::JavaScriptDialogType dialog_type,
47 const base::string16& message_text, 47 const base::string16& message_text,
48 const base::string16& default_prompt_text, 48 const base::string16& default_prompt_text,
49 const DialogClosedCallback& callback, 49 const DialogClosedCallback& callback,
50 bool* did_suppress_message) { 50 bool* did_suppress_message) {
51 base::DictionaryValue request_info; 51 base::DictionaryValue request_info;
52 request_info.Set( 52 request_info.Set(
53 webview::kDefaultPromptText, 53 webview::kDefaultPromptText,
54 new base::StringValue(base::UTF16ToUTF8(default_prompt_text))); 54 new base::StringValue(base::UTF16ToUTF8(default_prompt_text)));
55 request_info.Set(webview::kMessageText, 55 request_info.Set(webview::kMessageText,
56 new base::StringValue(base::UTF16ToUTF8(message_text))); 56 new base::StringValue(base::UTF16ToUTF8(message_text)));
57 request_info.Set(webview::kMessageType, 57 request_info.Set(
58 new base::StringValue( 58 webview::kMessageType,
59 JavaScriptMessageTypeToString(javascript_message_type))); 59 new base::StringValue(JavaScriptDialogTypeToString(dialog_type)));
60 request_info.Set(guest_view::kUrl, new base::StringValue(origin_url.spec())); 60 request_info.Set(guest_view::kUrl, new base::StringValue(origin_url.spec()));
61 WebViewPermissionHelper* web_view_permission_helper = 61 WebViewPermissionHelper* web_view_permission_helper =
62 WebViewPermissionHelper::FromWebContents(web_contents); 62 WebViewPermissionHelper::FromWebContents(web_contents);
63 web_view_permission_helper->RequestPermission( 63 web_view_permission_helper->RequestPermission(
64 WEB_VIEW_PERMISSION_TYPE_JAVASCRIPT_DIALOG, 64 WEB_VIEW_PERMISSION_TYPE_JAVASCRIPT_DIALOG,
65 request_info, 65 request_info,
66 base::Bind(&JavaScriptDialogHelper::OnPermissionResponse, 66 base::Bind(&JavaScriptDialogHelper::OnPermissionResponse,
67 base::Unretained(this), 67 base::Unretained(this),
68 callback), 68 callback),
69 false /* allowed_by_default */); 69 false /* allowed_by_default */);
(...skipping 20 matching lines...) Expand all
90 90
91 void JavaScriptDialogHelper::OnPermissionResponse( 91 void JavaScriptDialogHelper::OnPermissionResponse(
92 const DialogClosedCallback& callback, 92 const DialogClosedCallback& callback,
93 bool allow, 93 bool allow,
94 const std::string& user_input) { 94 const std::string& user_input) {
95 callback.Run(allow && web_view_guest_->attached(), 95 callback.Run(allow && web_view_guest_->attached(),
96 base::UTF8ToUTF16(user_input)); 96 base::UTF8ToUTF16(user_input));
97 } 97 }
98 98
99 } // namespace extensions 99 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/guest_view/web_view/javascript_dialog_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698