Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
index d361fefda9c53fe8b511c9ab578d450f32ff8f24..fe731e630e1bf15142943954a1c4adcd4cb21fbd 100644
--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
@@ -6232,7 +6232,7 @@ IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
namespace {
-// A BrowserMessageFilter that delays the FrameHostMsg_RunJavaScriptMessage IPC
+// A BrowserMessageFilter that delays the FrameHostMsg_RunJavaScriptDialog IPC
// message until a commit happens on a given WebContents. This allows testing a
// race condition.
class AllowDialogIPCOnCommitFilter : public BrowserMessageFilter,
@@ -6251,7 +6251,7 @@ class AllowDialogIPCOnCommitFilter : public BrowserMessageFilter,
// BrowserMessageFilter:
bool OnMessageReceived(const IPC::Message& message) override {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- if (message.type() != FrameHostMsg_RunJavaScriptMessage::ID)
+ if (message.type() != FrameHostMsg_RunJavaScriptDialog::ID)
return false;
// Suspend the message.

Powered by Google App Engine
This is Rietveld 408576698