Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl_browsertest.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index 53a86d7cd7902c39816404fbd63203f49f0c0da2..03a09d873526710a85f7bd798a981ac200baec70 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -2500,10 +2500,10 @@ TEST_F(WebContentsImplTest, NoJSMessageOnInterstitials) {
// While the interstitial is showing, let's simulate the hidden page
// attempting to show a JS message.
IPC::Message* dummy_message = new IPC::Message;
- contents()->RunJavaScriptMessage(main_test_rfh(),
- base::ASCIIToUTF16("This is an informative message"),
- base::ASCIIToUTF16("OK"),
- kGURL, JAVASCRIPT_MESSAGE_TYPE_ALERT, dummy_message);
+ contents()->RunJavaScriptDialog(
+ main_test_rfh(), base::ASCIIToUTF16("This is an informative message"),
+ base::ASCIIToUTF16("OK"), kGURL, JAVASCRIPT_DIALOG_TYPE_ALERT,
+ dummy_message);
EXPECT_TRUE(contents()->last_dialog_suppressed_);
}
@@ -3391,7 +3391,7 @@ class TestJavaScriptDialogManager : public JavaScriptDialogManager {
void RunJavaScriptDialog(WebContents* web_contents,
const GURL& origin_url,
- JavaScriptMessageType javascript_message_type,
+ JavaScriptDialogType dialog_type,
const base::string16& message_text,
const base::string16& default_prompt_text,
const DialogClosedCallback& callback,
« no previous file with comments | « content/browser/web_contents/web_contents_impl_browsertest.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698