Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.h

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/javascript_dialog_helper.h
diff --git a/extensions/browser/guest_view/web_view/javascript_dialog_helper.h b/extensions/browser/guest_view/web_view/javascript_dialog_helper.h
index 87e63cb41459918e7748866c5452719cc15abd25..257108f84f7b2e3d172684e08b2dd70e990ef7b8 100644
--- a/extensions/browser/guest_view/web_view/javascript_dialog_helper.h
+++ b/extensions/browser/guest_view/web_view/javascript_dialog_helper.h
@@ -18,14 +18,13 @@ class JavaScriptDialogHelper : public content::JavaScriptDialogManager {
~JavaScriptDialogHelper() override;
// JavaScriptDialogManager implementation.
- void RunJavaScriptDialog(
- content::WebContents* web_contents,
- const GURL& origin_url,
- content::JavaScriptMessageType javascript_message_type,
- const base::string16& message_text,
- const base::string16& default_prompt_text,
- const DialogClosedCallback& callback,
- bool* did_suppress_message) override;
+ void RunJavaScriptDialog(content::WebContents* web_contents,
+ const GURL& origin_url,
+ content::JavaScriptDialogType dialog_type,
+ const base::string16& message_text,
+ const base::string16& default_prompt_text,
+ const DialogClosedCallback& callback,
+ bool* did_suppress_message) override;
void RunBeforeUnloadDialog(content::WebContents* web_contents,
bool is_reload,
const DialogClosedCallback& callback) override;

Powered by Google App Engine
This is Rietveld 408576698