content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc - Issue 2684093002: Rename JavaScript "messages" to "dialogs".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)

Patch Set: win fox Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h ('k') | content/shell/browser/shell_javascript_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc

diff --git a/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc b/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc

index 7e5076d66eb9dcf8f54f100250841c05b2ae99a7..756d7a908b2a6d3f2ae8998bc296ca13755db6ae 100644

--- a/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc

+++ b/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc

@@ -23,7 +23,7 @@ LayoutTestJavaScriptDialogManager::~LayoutTestJavaScriptDialogManager() {

void LayoutTestJavaScriptDialogManager::RunJavaScriptDialog(

WebContents* web_contents,

const GURL& origin_url,

- JavaScriptMessageType javascript_message_type,

+ JavaScriptDialogType dialog_type,

const base::string16& message_text,

const base::string16& default_prompt_text,

const DialogClosedCallback& callback,