Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: components/app_modal/javascript_app_modal_dialog.cc

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal/javascript_app_modal_dialog.cc
diff --git a/components/app_modal/javascript_app_modal_dialog.cc b/components/app_modal/javascript_app_modal_dialog.cc
index 7a48f2a3a598e593854675648b3c090a0d3f7be9..dd5808078b05ff3e564dc7f79a5dc1de520f5c64 100644
--- a/components/app_modal/javascript_app_modal_dialog.cc
+++ b/components/app_modal/javascript_app_modal_dialog.cc
@@ -59,7 +59,7 @@ JavaScriptAppModalDialog::JavaScriptAppModalDialog(
content::WebContents* web_contents,
ExtraDataMap* extra_data_map,
const base::string16& title,
- content::JavaScriptMessageType javascript_message_type,
+ content::JavaScriptDialogType javascript_dialog_type,
const base::string16& message_text,
const base::string16& default_prompt_text,
bool display_suppress_checkbox,
@@ -68,7 +68,7 @@ JavaScriptAppModalDialog::JavaScriptAppModalDialog(
const content::JavaScriptDialogManager::DialogClosedCallback& callback)
: AppModalDialog(web_contents, title),
extra_data_map_(extra_data_map),
- javascript_message_type_(javascript_message_type),
+ javascript_dialog_type_(javascript_dialog_type),
display_suppress_checkbox_(display_suppress_checkbox),
is_before_unload_dialog_(is_before_unload_dialog),
is_reload_(is_reload),
« no previous file with comments | « components/app_modal/javascript_app_modal_dialog.h ('k') | components/app_modal/javascript_dialog_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698