Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1891)

Unified Diff: content/shell/browser/shell_javascript_dialog_mac.mm

Issue 2684093002: Rename JavaScript "messages" to "dialogs". (Closed)
Patch Set: win fox Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_javascript_dialog_mac.mm
diff --git a/content/shell/browser/shell_javascript_dialog_mac.mm b/content/shell/browser/shell_javascript_dialog_mac.mm
index 73b0f4bfd63d46bf23839fcb2846615d00ccb9cc..ba3199a717869145dbc869080ea18a72fb2c7947 100644
--- a/content/shell/browser/shell_javascript_dialog_mac.mm
+++ b/content/shell/browser/shell_javascript_dialog_mac.mm
@@ -89,13 +89,13 @@ namespace content {
ShellJavaScriptDialog::ShellJavaScriptDialog(
ShellJavaScriptDialogManager* manager,
gfx::NativeWindow parent_window,
- JavaScriptMessageType message_type,
+ JavaScriptDialogType dialog_type,
const base::string16& message_text,
const base::string16& default_prompt_text,
const JavaScriptDialogManager::DialogClosedCallback& callback)
: callback_(callback) {
- bool text_field = message_type == JAVASCRIPT_MESSAGE_TYPE_PROMPT;
- bool one_button = message_type == JAVASCRIPT_MESSAGE_TYPE_ALERT;
+ bool text_field = dialog_type == JAVASCRIPT_DIALOG_TYPE_PROMPT;
+ bool one_button = dialog_type == JAVASCRIPT_DIALOG_TYPE_ALERT;
helper_ =
[[ShellJavaScriptDialogHelper alloc] initHelperWithManager:manager
« no previous file with comments | « content/shell/browser/shell_javascript_dialog.h ('k') | content/shell/browser/shell_javascript_dialog_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698