Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2389253002: reflow comments in modules/{webaudio,vr} (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
bajones, Raymond Toy
CC:
chromium-reviews, blink-reviews, haraken, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in modules/{webaudio,vr} BUG=563793 Committed: https://crrev.com/4215d1e8125bc3d8084c3a72da49e9b985ed04b8 Cr-Commit-Position: refs/heads/master@{#422920}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1016 lines, -744 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp View 1 2 4 chunks +15 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandler.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandler.cpp View 1 2 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h View 1 2 5 chunks +20 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp View 1 2 19 chunks +81 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.cpp View 4 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp View 1 2 4 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioListener.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioListener.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.h View 1 2 8 chunks +38 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 1 2 6 chunks +41 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNodeInput.h View 1 2 2 chunks +18 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp View 1 2 3 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.h View 1 2 5 chunks +36 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp View 1 2 3 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParam.h View 7 chunks +18 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParam.cpp View 12 chunks +31 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h View 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp View 31 chunks +168 lines, -140 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h View 3 chunks +20 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp View 1 2 6 chunks +16 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h View 1 2 3 10 chunks +38 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp View 1 2 11 chunks +31 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp View 1 2 4 chunks +21 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadProcessor.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadProcessor.cpp View 1 2 4 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ConvolverNode.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp View 1 2 6 chunks +21 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.h View 1 2 4 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/GainNode.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/GainNode.cpp View 1 2 6 chunks +17 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h View 1 2 2 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 2 3 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 2 4 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OscillatorNode.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp View 1 2 5 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.h View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.cpp View 1 2 5 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PeriodicWave.h View 3 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PeriodicWave.cpp View 11 chunks +47 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp View 1 2 7 chunks +21 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp View 1 2 7 chunks +30 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.cpp View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Nico
bajones: The one vr file rtoy: The 65 webaudio files (sorry)
4 years, 2 months ago (2016-10-04 18:18:50 UTC) #6
bajones
On 2016/10/04 18:18:50, Nico wrote: > bajones: The one vr file > rtoy: The 65 ...
4 years, 2 months ago (2016-10-04 18:28:04 UTC) #7
Raymond Toy
Assuming this was all done by machine, lgtm.
4 years, 2 months ago (2016-10-04 20:12:49 UTC) #8
Nico
On 2016/10/04 20:12:49, Raymond Toy wrote: > Assuming this was all done by machine, lgtm. ...
4 years, 2 months ago (2016-10-04 20:19:51 UTC) #11
Raymond Toy
On 2016/10/04 20:19:51, Nico wrote: > On 2016/10/04 20:12:49, Raymond Toy wrote: > > Assuming ...
4 years, 2 months ago (2016-10-04 20:34:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389253002/60001
4 years, 2 months ago (2016-10-04 20:40:18 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-04 20:48:52 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 20:50:01 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4215d1e8125bc3d8084c3a72da49e9b985ed04b8
Cr-Commit-Position: refs/heads/master@{#422920}

Powered by Google App Engine
This is Rietveld 408576698