Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp

Issue 2389253002: reflow comments in modules/{webaudio,vr} (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp b/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp
index 11126ea08d4644e9fbb7ff1d5974c5c0f829d29f..4d0330b19f35af7080c9228ea9db00b9df84a432 100644
--- a/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp
@@ -40,12 +40,13 @@ void IIRDSPKernel::getFrequencyResponse(int nFrequencies,
}
double IIRDSPKernel::tailTime() const {
- // TODO(rtoy): This is true mathematically (infinite impulse response), but perhaps it should be
- // limited to a smaller value, possibly based on the actual filter coefficients. To do that, we
- // would probably need to find the pole, r, with largest magnitude and select some threshold,
- // eps, such that |r|^n < eps for all n >= N. N is then the tailTime for the filter. If the
- // the magnitude of r is greater than or equal to 1, the infinity is the right answer. (There is
- // no constraint on the IIR filter that it be stable.)
+ // TODO(rtoy): This is true mathematically (infinite impulse response), but
+ // perhaps it should be limited to a smaller value, possibly based on the
+ // actual filter coefficients. To do that, we would probably need to find the
+ // pole, r, with largest magnitude and select some threshold, eps, such that
+ // |r|^n < eps for all n >= N. N is then the tailTime for the filter. If the
+ // the magnitude of r is greater than or equal to 1, the infinity is the right
+ // answer. (There is no constraint on the IIR filter that it be stable.)
return std::numeric_limits<double>::infinity();
}
« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/GainNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698