Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in Source/bindings/. - We should specify just one of them to a function. This was done by the following command. % sed -i "" -E "s/virtual (.*) final/\1 final/g; s/virtual (.*) override/\1 override/g; s/override final/final/g" <files> - Non-base virtual destructors should have |override| keywords. This CL has no behavior changes. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -146 lines) Patch
M Source/bindings/core/v8/CallbackPromiseAdapter.h View 10 chunks +18 lines, -18 lines 0 comments Download
M Source/bindings/core/v8/ExceptionState.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/bindings/core/v8/ExceptionStatePlaceholder.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/ScriptHeapSnapshot.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptProfiler.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseProperty.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptStreamer.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptValueSerializer.h View 6 chunks +24 lines, -24 lines 0 comments Download
M Source/bindings/core/v8/ScriptWrappable.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8AbstractEventListener.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8BindingForTesting.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/V8ErrorHandler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8EventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8GCController.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8LazyEventListener.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8MutationCallback.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8NodeFilterCondition.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8ScriptRunnerTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8StringResource.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8CustomXPathNSResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/ScriptValueSerializerForModules.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/templates/callback_interface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestCallbackInterface.h View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
haraken@, please review this trivial change when you have spare time.
5 years, 5 months ago (2015-07-10 01:25:07 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-07-10 01:28:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236473002/1
5 years, 5 months ago (2015-07-10 01:40:12 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 01:44:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198647

Powered by Google App Engine
This is Rietveld 408576698