Source/bindings/core/v8/V8ErrorHandler.h - Issue 1236473002: Fix virtual/override/final usage in Source/bindings/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8ErrorHandler.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8ErrorHandler.h

diff --git a/Source/bindings/core/v8/V8ErrorHandler.h b/Source/bindings/core/v8/V8ErrorHandler.h

index 991fa50f4116d8b6e34c16922b511969ce7b9500..ab1d8f0a71f3d95a88d614aa606ae56e0748ee16 100644

--- a/Source/bindings/core/v8/V8ErrorHandler.h

+++ b/Source/bindings/core/v8/V8ErrorHandler.h

@@ -49,8 +49,8 @@ public:

private:

V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, ScriptState*);

- virtual v8::Local<v8::Value> callListenerFunction(ScriptState*, v8::Local<v8::Value>, Event*) override;

- virtual bool shouldPreventDefault(v8::Local<v8::Value> returnValue) override;

+ v8::Local<v8::Value> callListenerFunction(ScriptState*, v8::Local<v8::Value>, Event*) override;

+ bool shouldPreventDefault(v8::Local<v8::Value> returnValue) override;

};

} // namespace blink