Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: Source/bindings/core/v8/V8StringResource.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8StringResource.h
diff --git a/Source/bindings/core/v8/V8StringResource.h b/Source/bindings/core/v8/V8StringResource.h
index 874ac5eee04105e828e163c0ccf8f859709ff7c3..7c1cd5669108407031da19739856a26e166ed92c 100644
--- a/Source/bindings/core/v8/V8StringResource.h
+++ b/Source/bindings/core/v8/V8StringResource.h
@@ -120,8 +120,8 @@ public:
ASSERT(!string.is8Bit());
}
- virtual size_t length() const override { return m_plainString.impl()->length(); }
- virtual const uint16_t* data() const override
+ size_t length() const override { return m_plainString.impl()->length(); }
+ const uint16_t* data() const override
{
return reinterpret_cast<const uint16_t*>(m_plainString.impl()->characters16());
}
@@ -141,8 +141,8 @@ public:
ASSERT(string.is8Bit());
}
- virtual size_t length() const override { return m_plainString.impl()->length(); }
- virtual const char* data() const override
+ size_t length() const override { return m_plainString.impl()->length(); }
+ const char* data() const override
{
return reinterpret_cast<const char*>(m_plainString.impl()->characters8());
}
« no previous file with comments | « Source/bindings/core/v8/V8ScriptRunnerTest.cpp ('k') | Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698