Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: Source/bindings/core/v8/ExceptionState.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ExceptionState.h
diff --git a/Source/bindings/core/v8/ExceptionState.h b/Source/bindings/core/v8/ExceptionState.h
index 695aa16117f137ae56b1aa0b82d4e1273a2619d8..f4d2351e980b48f72017dab086cee2f67885a536 100644
--- a/Source/bindings/core/v8/ExceptionState.h
+++ b/Source/bindings/core/v8/ExceptionState.h
@@ -142,20 +142,20 @@ private:
class CORE_EXPORT NonThrowableExceptionState final : public ExceptionState {
public:
NonThrowableExceptionState(): ExceptionState(ExceptionState::UnknownContext, 0, 0, v8::Local<v8::Object>(), v8::Isolate::GetCurrent()) { }
- virtual void throwDOMException(const ExceptionCode&, const String& message) override;
- virtual void throwTypeError(const String& message = String()) override;
- virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) override;
- virtual void throwRangeError(const String& message) override;
+ void throwDOMException(const ExceptionCode&, const String& message) override;
+ void throwTypeError(const String& message = String()) override;
+ void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) override;
+ void throwRangeError(const String& message) override;
};
// Used if any exceptions thrown are ignorable.
class CORE_EXPORT TrackExceptionState final : public ExceptionState {
public:
TrackExceptionState(): ExceptionState(ExceptionState::UnknownContext, 0, 0, v8::Local<v8::Object>(), v8::Isolate::GetCurrent()) { }
- virtual void throwDOMException(const ExceptionCode&, const String& message) override;
- virtual void throwTypeError(const String& message = String()) override;
- virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) override;
- virtual void throwRangeError(const String& message) override;
+ void throwDOMException(const ExceptionCode&, const String& message) override;
+ void throwTypeError(const String& message = String()) override;
+ void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) override;
+ void throwRangeError(const String& message) override;
};
} // namespace blink
« no previous file with comments | « Source/bindings/core/v8/CallbackPromiseAdapter.h ('k') | Source/bindings/core/v8/ExceptionStatePlaceholder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698