Source/bindings/core/v8/ScriptPromiseTest.cpp - Issue 1236473002: Fix virtual/override/final usage in Source/bindings/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptPromiseTest.cpp

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptPromiseTest.cpp

diff --git a/Source/bindings/core/v8/ScriptPromiseTest.cpp b/Source/bindings/core/v8/ScriptPromiseTest.cpp

index f113f76fbf953d3fa025d8bc39d5922975882702..04ebbd6fdee988d1e97d82602035fbab461dac42 100644

--- a/Source/bindings/core/v8/ScriptPromiseTest.cpp

+++ b/Source/bindings/core/v8/ScriptPromiseTest.cpp

@@ -62,7 +62,7 @@ private:

{

}

- virtual ScriptValue call(ScriptValue value) override

+ ScriptValue call(ScriptValue value) override

{

ASSERT(!value.isEmpty());

*m_value = toCoreString(value.v8Value()->ToString(scriptState()->context()).ToLocalChecked());