Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: Source/bindings/core/v8/V8AbstractEventListener.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptWrappable.h ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8AbstractEventListener.h
diff --git a/Source/bindings/core/v8/V8AbstractEventListener.h b/Source/bindings/core/v8/V8AbstractEventListener.h
index 6b5d1cb615890d471d5003976855a1f6b14bed98..dc609751121607b7795e3ecfad8b1b0fd4bcf2e5 100644
--- a/Source/bindings/core/v8/V8AbstractEventListener.h
+++ b/Source/bindings/core/v8/V8AbstractEventListener.h
@@ -53,7 +53,7 @@ class Event;
// but ALLOWs duplicated non-HTML event handlers.
class CORE_EXPORT V8AbstractEventListener : public EventListener {
public:
- virtual ~V8AbstractEventListener();
+ ~V8AbstractEventListener() override;
static const V8AbstractEventListener* cast(const EventListener* listener)
{
@@ -69,9 +69,9 @@ public:
// Implementation of EventListener interface.
- virtual bool operator==(const EventListener& other) override { return this == &other; }
+ bool operator==(const EventListener& other) override { return this == &other; }
- virtual void handleEvent(ExecutionContext*, Event*) override final;
+ void handleEvent(ExecutionContext*, Event*) final;
virtual void handleEvent(ScriptState*, Event*);
// Returns the listener object, either a function or an object.
@@ -108,7 +108,7 @@ public:
m_listener.clear();
}
- virtual bool belongsToTheCurrentWorld() const override final;
+ bool belongsToTheCurrentWorld() const final;
v8::Isolate* isolate() const { return m_isolate; }
DOMWrapperWorld& world() const { return *m_world; }
@@ -126,7 +126,7 @@ protected:
private:
// Implementation of EventListener function.
- virtual bool virtualisAttribute() const override { return m_isAttribute; }
+ bool virtualisAttribute() const override { return m_isAttribute; }
// This could return an empty handle and callers need to check return value.
// We don't use v8::MaybeLocal because it can fail without exception.
« no previous file with comments | « Source/bindings/core/v8/ScriptWrappable.h ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698