Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h - Issue 1236473002: Fix virtual/override/final usage in Source/bindings/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/modules/v8/ScriptValueSerializerForModules.h ('k') | Source/bindings/templates/callback_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

diff --git a/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h b/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

index 55e6629708ae503a1a331fcc8695eb28bf22eb0c..8ec86c9e20e7b47f5ce7637fc38e8b60d151ca83 100644

--- a/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

+++ b/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

@@ -15,13 +15,13 @@ class SerializedScriptValueForModulesFactory final : public SerializedScriptValu

public:

SerializedScriptValueForModulesFactory() : SerializedScriptValueFactory() { }

- virtual PassRefPtr<SerializedScriptValue> create(v8::Isolate*, v8::Local<v8::Value>, MessagePortArray*, ArrayBufferArray*, WebBlobInfoArray*, ExceptionState&) override;

- virtual PassRefPtr<SerializedScriptValue> create(v8::Isolate*, const String&) override;

+ PassRefPtr<SerializedScriptValue> create(v8::Isolate*, v8::Local<v8::Value>, MessagePortArray*, ArrayBufferArray*, WebBlobInfoArray*, ExceptionState&) override;

+ PassRefPtr<SerializedScriptValue> create(v8::Isolate*, const String&) override;

protected:

- virtual ScriptValueSerializer::Status doSerialize(v8::Local<v8::Value>, SerializedScriptValueWriter&, MessagePortArray*, ArrayBufferArray*, WebBlobInfoArray*, BlobDataHandleMap&, v8::TryCatch&, String& errorMessage, v8::Isolate*) override;

+ ScriptValueSerializer::Status doSerialize(v8::Local<v8::Value>, SerializedScriptValueWriter&, MessagePortArray*, ArrayBufferArray*, WebBlobInfoArray*, BlobDataHandleMap&, v8::TryCatch&, String& errorMessage, v8::Isolate*) override;

- virtual v8::Local<v8::Value> deserialize(String& data, BlobDataHandleMap& blobDataHandles, ArrayBufferContentsArray*, v8::Isolate*, MessagePortArray* messagePorts, const WebBlobInfoArray*) override;

+ v8::Local<v8::Value> deserialize(String& data, BlobDataHandleMap& blobDataHandles, ArrayBufferContentsArray*, v8::Isolate*, MessagePortArray* messagePorts, const WebBlobInfoArray*) override;

};

} // namespace blink

« no previous file with comments | « Source/bindings/modules/v8/ScriptValueSerializerForModules.h ('k') | Source/bindings/templates/callback_interface.h » ('j') | no next file with comments »