Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8BindingForTesting.h ('k') | Source/bindings/core/v8/V8ErrorHandler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h
diff --git a/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h b/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h
index 6b06af6ad804932f4eb8dac074896326de414801..64071e674e9728662a17279df15429917d42a8f4 100644
--- a/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h
+++ b/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h
@@ -51,7 +51,7 @@ class V8CustomElementLifecycleCallbacks final : public CustomElementLifecycleCal
public:
static PassRefPtrWillBeRawPtr<V8CustomElementLifecycleCallbacks> create(ScriptState*, v8::Local<v8::Object> prototype, v8::MaybeLocal<v8::Function> created, v8::MaybeLocal<v8::Function> attached, v8::MaybeLocal<v8::Function> detached, v8::MaybeLocal<v8::Function> attributeChanged);
- virtual ~V8CustomElementLifecycleCallbacks();
+ ~V8CustomElementLifecycleCallbacks() override;
bool setBinding(CustomElementDefinition* owner, PassOwnPtr<CustomElementBinding>);
@@ -60,10 +60,10 @@ public:
private:
V8CustomElementLifecycleCallbacks(ScriptState*, v8::Local<v8::Object> prototype, v8::MaybeLocal<v8::Function> created, v8::MaybeLocal<v8::Function> attached, v8::MaybeLocal<v8::Function> detached, v8::MaybeLocal<v8::Function> attributeChanged);
- virtual void created(Element*) override;
- virtual void attached(Element*) override;
- virtual void detached(Element*) override;
- virtual void attributeChanged(Element*, const AtomicString& name, const AtomicString& oldValue, const AtomicString& newValue) override;
+ void created(Element*) override;
+ void attached(Element*) override;
+ void detached(Element*) override;
+ void attributeChanged(Element*, const AtomicString& name, const AtomicString& oldValue, const AtomicString& newValue) override;
void call(const ScopedPersistent<v8::Function>& weakCallback, Element*);
« no previous file with comments | « Source/bindings/core/v8/V8BindingForTesting.h ('k') | Source/bindings/core/v8/V8ErrorHandler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698