Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: Source/bindings/core/v8/ScriptStreamer.cpp

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPromiseTest.cpp ('k') | Source/bindings/core/v8/ScriptStreamerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptStreamer.cpp
diff --git a/Source/bindings/core/v8/ScriptStreamer.cpp b/Source/bindings/core/v8/ScriptStreamer.cpp
index 3387a585f701ee349919e54ecd3da5f255bb17b0..3f388af2a9f9d94b182a21ff8a418739380e32f6 100644
--- a/Source/bindings/core/v8/ScriptStreamer.cpp
+++ b/Source/bindings/core/v8/ScriptStreamer.cpp
@@ -172,11 +172,11 @@ public:
{
}
- virtual ~SourceStream() { }
+ virtual ~SourceStream() override { }
// Called by V8 on a background thread. Should block until we can return
// some data.
- virtual size_t GetMoreData(const uint8_t** src) override
+ size_t GetMoreData(const uint8_t** src) override
{
ASSERT(!isMainThread());
{
@@ -197,7 +197,7 @@ public:
}
// Called by V8 on background thread.
- virtual bool SetBookmark() override
+ bool SetBookmark() override
{
ASSERT(!isMainThread());
m_bookmarkPosition = m_queueLeadPosition;
@@ -205,7 +205,7 @@ public:
}
// Called by V8 on background thread.
- virtual void ResetToBookmark() override
+ void ResetToBookmark() override
{
ASSERT(!isMainThread());
{
« no previous file with comments | « Source/bindings/core/v8/ScriptPromiseTest.cpp ('k') | Source/bindings/core/v8/ScriptStreamerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698