Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: Source/bindings/core/v8/ScriptProfiler.cpp

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptHeapSnapshot.cpp ('k') | Source/bindings/core/v8/ScriptPromiseProperty.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptProfiler.cpp
diff --git a/Source/bindings/core/v8/ScriptProfiler.cpp b/Source/bindings/core/v8/ScriptProfiler.cpp
index 0d0f45ed230856aefc7259b592df65a130583c8c..91a530e176dfd8bcf28f065b49c991b2b2de83ae 100644
--- a/Source/bindings/core/v8/ScriptProfiler.cpp
+++ b/Source/bindings/core/v8/ScriptProfiler.cpp
@@ -143,7 +143,7 @@ class ActivityControlAdapter final : public v8::ActivityControl {
public:
ActivityControlAdapter(ScriptProfiler::HeapSnapshotProgress* progress)
: m_progress(progress), m_firstReport(true) { }
- virtual ControlOption ReportProgressValue(int done, int total) override
+ ControlOption ReportProgressValue(int done, int total) override
{
ControlOption result = m_progress->isCanceled() ? kAbort : kContinue;
if (m_firstReport) {
@@ -163,7 +163,7 @@ private:
class GlobalObjectNameResolver final : public v8::HeapProfiler::ObjectNameResolver {
public:
- virtual const char* GetName(v8::Local<v8::Object> object) override
+ const char* GetName(v8::Local<v8::Object> object) override
{
DOMWindow* window = toDOMWindow(v8::Isolate::GetCurrent(), object);
if (!window)
@@ -189,15 +189,15 @@ namespace {
class HeapStatsStream : public v8::OutputStream {
public:
HeapStatsStream(ScriptProfiler::OutputStream* stream) : m_stream(stream) { }
- virtual void EndOfStream() override { }
+ void EndOfStream() override { }
- virtual WriteResult WriteAsciiChunk(char* data, int size) override
+ WriteResult WriteAsciiChunk(char* data, int size) override
{
ASSERT(false);
return kAbort;
}
- virtual WriteResult WriteHeapStatsChunk(v8::HeapStatsUpdate* updateData, int count) override
+ WriteResult WriteHeapStatsChunk(v8::HeapStatsUpdate* updateData, int count) override
{
Vector<uint32_t> rawData(count * 3);
for (int i = 0; i < count; ++i) {
« no previous file with comments | « Source/bindings/core/v8/ScriptHeapSnapshot.cpp ('k') | Source/bindings/core/v8/ScriptPromiseProperty.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698