Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: Source/bindings/core/v8/V8ScriptRunnerTest.cpp

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "bindings/core/v8/V8ScriptRunner.h" 6 #include "bindings/core/v8/V8ScriptRunner.h"
7 7
8 #include "bindings/core/v8/V8Binding.h" 8 #include "bindings/core/v8/V8Binding.h"
9 #include "bindings/core/v8/V8BindingForTesting.h" 9 #include "bindings/core/v8/V8BindingForTesting.h"
10 #include "core/fetch/CachedMetadataHandler.h" 10 #include "core/fetch/CachedMetadataHandler.h"
11 #include "core/fetch/ScriptResource.h" 11 #include "core/fetch/ScriptResource.h"
12 #include "platform/heap/Handle.h" 12 #include "platform/heap/Handle.h"
13 #include <gtest/gtest.h> 13 #include <gtest/gtest.h>
14 #include <v8.h> 14 #include <v8.h>
15 15
16 namespace blink { 16 namespace blink {
17 17
18 namespace { 18 namespace {
19 19
20 class V8ScriptRunnerTest : public ::testing::Test { 20 class V8ScriptRunnerTest : public ::testing::Test {
21 public: 21 public:
22 V8ScriptRunnerTest() : m_scope(v8::Isolate::GetCurrent()) { } 22 V8ScriptRunnerTest() : m_scope(v8::Isolate::GetCurrent()) { }
23 virtual ~V8ScriptRunnerTest() { } 23 ~V8ScriptRunnerTest() override { }
24 24
25 virtual void SetUp() override 25 void SetUp() override
26 { 26 {
27 // To trick various layers of caching, increment a counter for each 27 // To trick various layers of caching, increment a counter for each
28 // test and use it in code(), fielname() and url(). 28 // test and use it in code(), fielname() and url().
29 counter++; 29 counter++;
30 } 30 }
31 31
32 virtual void TearDown() override 32 void TearDown() override
33 { 33 {
34 m_resourceRequest.clear(); 34 m_resourceRequest.clear();
35 m_resource.clear(); 35 m_resource.clear();
36 } 36 }
37 37
38 v8::Isolate* isolate() const 38 v8::Isolate* isolate() const
39 { 39 {
40 return m_scope.isolate(); 40 return m_scope.isolate();
41 } 41 }
42 WTF::String code() const 42 WTF::String code() const
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 EXPECT_TRUE(cacheHandler()->cachedMetadata(tagForCodeCache(cacheHandler()))) ; 135 EXPECT_TRUE(cacheHandler()->cachedMetadata(tagForCodeCache(cacheHandler()))) ;
136 // The cached data is associated with the encoding. 136 // The cached data is associated with the encoding.
137 ResourceRequest request(url()); 137 ResourceRequest request(url());
138 ResourcePtr<ScriptResource> anotherResource = new ScriptResource(request, "U TF-16"); 138 ResourcePtr<ScriptResource> anotherResource = new ScriptResource(request, "U TF-16");
139 EXPECT_FALSE(cacheHandler()->cachedMetadata(tagForCodeCache(anotherResource- >cacheHandler()))); 139 EXPECT_FALSE(cacheHandler()->cachedMetadata(tagForCodeCache(anotherResource- >cacheHandler())));
140 } 140 }
141 141
142 } // namespace 142 } // namespace
143 143
144 } // namespace blink 144 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8NodeFilterCondition.h ('k') | Source/bindings/core/v8/V8StringResource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698