Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: Source/bindings/core/v8/V8LazyEventListener.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Initializer.cpp ('k') | Source/bindings/core/v8/V8MutationCallback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8LazyEventListener.h
diff --git a/Source/bindings/core/v8/V8LazyEventListener.h b/Source/bindings/core/v8/V8LazyEventListener.h
index 03c37ecff2e847c4966332c0a6e3ec3fb182203c..32fc97a93cece1b927da56e07ab28c967587104c 100644
--- a/Source/bindings/core/v8/V8LazyEventListener.h
+++ b/Source/bindings/core/v8/V8LazyEventListener.h
@@ -51,18 +51,18 @@ public:
}
protected:
- virtual void prepareListenerObject(ExecutionContext*) override;
+ void prepareListenerObject(ExecutionContext*) override;
private:
V8LazyEventListener(v8::Isolate*, const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition&, Node*);
- virtual v8::Local<v8::Value> callListenerFunction(ScriptState*, v8::Local<v8::Value>, Event*) override;
+ v8::Local<v8::Value> callListenerFunction(ScriptState*, v8::Local<v8::Value>, Event*) override;
// Needs to return true for all event handlers implemented in JavaScript so that
// the SVG code does not add the event handler in both
// SVGUseElement::buildShadowTree and again in
// SVGUseElement::transferEventListenersToShadowTree
- virtual bool wasCreatedFromMarkup() const override { return true; }
+ bool wasCreatedFromMarkup() const override { return true; }
AtomicString m_functionName;
AtomicString m_eventParameterName;
« no previous file with comments | « Source/bindings/core/v8/V8Initializer.cpp ('k') | Source/bindings/core/v8/V8MutationCallback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698