Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: Source/bindings/core/v8/ExceptionStatePlaceholder.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ExceptionState.h ('k') | Source/bindings/core/v8/ScriptHeapSnapshot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ExceptionStatePlaceholder.h
diff --git a/Source/bindings/core/v8/ExceptionStatePlaceholder.h b/Source/bindings/core/v8/ExceptionStatePlaceholder.h
index 222ead754552a84de59b71f8dd3cdcaee4675c42..9705c5d59cc087050be95c050eb715219a041f37 100644
--- a/Source/bindings/core/v8/ExceptionStatePlaceholder.h
+++ b/Source/bindings/core/v8/ExceptionStatePlaceholder.h
@@ -47,9 +47,9 @@ class IgnorableExceptionState final : public ExceptionState {
public:
IgnorableExceptionState(): ExceptionState(ExceptionState::UnknownContext, 0, 0, v8::Local<v8::Object>(), 0) { }
ExceptionState& returnThis() { return *this; }
- virtual void throwDOMException(const ExceptionCode&, const String& message = String()) override { }
- virtual void throwTypeError(const String& message = String()) override { }
- virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) override { }
+ void throwDOMException(const ExceptionCode&, const String& message = String()) override { }
+ void throwTypeError(const String& message = String()) override { }
+ void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) override { }
};
#define IGNORE_EXCEPTION (::blink::IgnorableExceptionState().returnThis())
@@ -60,9 +60,9 @@ class CORE_EXPORT NoExceptionStateAssertionChecker final : public ExceptionState
public:
NoExceptionStateAssertionChecker(const char* file, int line);
ExceptionState& returnThis() { return *this; }
- virtual void throwDOMException(const ExceptionCode&, const String& message = String()) override;
- virtual void throwTypeError(const String& message = String()) override;
- virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) override;
+ void throwDOMException(const ExceptionCode&, const String& message = String()) override;
+ void throwTypeError(const String& message = String()) override;
+ void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) override;
private:
const char* m_file;
« no previous file with comments | « Source/bindings/core/v8/ExceptionState.h ('k') | Source/bindings/core/v8/ScriptHeapSnapshot.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698