Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: Source/bindings/core/v8/ScriptPromiseResolver.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ScriptPromiseResolver_h 5 #ifndef ScriptPromiseResolver_h
6 #define ScriptPromiseResolver_h 6 #define ScriptPromiseResolver_h
7 7
8 #include "bindings/core/v8/ScopedPersistent.h" 8 #include "bindings/core/v8/ScopedPersistent.h"
9 #include "bindings/core/v8/ScriptPromise.h" 9 #include "bindings/core/v8/ScriptPromise.h"
10 #include "bindings/core/v8/ScriptState.h" 10 #include "bindings/core/v8/ScriptState.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 { 77 {
78 #if ENABLE(ASSERT) 78 #if ENABLE(ASSERT)
79 m_isPromiseCalled = true; 79 m_isPromiseCalled = true;
80 #endif 80 #endif
81 return m_resolver.promise(); 81 return m_resolver.promise();
82 } 82 }
83 83
84 ScriptState* scriptState() const { return m_scriptState.get(); } 84 ScriptState* scriptState() const { return m_scriptState.get(); }
85 85
86 // ActiveDOMObject implementation. 86 // ActiveDOMObject implementation.
87 virtual void suspend() override; 87 void suspend() override;
88 virtual void resume() override; 88 void resume() override;
89 virtual void stop() override; 89 void stop() override;
90 90
91 // Once this function is called this resolver stays alive while the 91 // Once this function is called this resolver stays alive while the
92 // promise is pending and the associated ExecutionContext isn't stopped. 92 // promise is pending and the associated ExecutionContext isn't stopped.
93 void keepAliveWhilePending(); 93 void keepAliveWhilePending();
94 94
95 DECLARE_VIRTUAL_TRACE(); 95 DECLARE_VIRTUAL_TRACE();
96 96
97 protected: 97 protected:
98 // You need to call suspendIfNeeded after the construction because 98 // You need to call suspendIfNeeded after the construction because
99 // this is an ActiveDOMObject. 99 // this is an ActiveDOMObject.
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 ScopedPersistent<v8::Value> m_value; 143 ScopedPersistent<v8::Value> m_value;
144 #if ENABLE(ASSERT) 144 #if ENABLE(ASSERT)
145 // True if promise() is called. 145 // True if promise() is called.
146 bool m_isPromiseCalled; 146 bool m_isPromiseCalled;
147 #endif 147 #endif
148 }; 148 };
149 149
150 } // namespace blink 150 } // namespace blink
151 151
152 #endif // ScriptPromiseResolver_h 152 #endif // ScriptPromiseResolver_h
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptPromisePropertyTest.cpp ('k') | Source/bindings/core/v8/ScriptPromiseResolverTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698