Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: Source/bindings/core/v8/ScriptWrappable.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptValueSerializer.h ('k') | Source/bindings/core/v8/V8AbstractEventListener.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptWrappable.h
diff --git a/Source/bindings/core/v8/ScriptWrappable.h b/Source/bindings/core/v8/ScriptWrappable.h
index f52e55a9857be76fd4758ba9450e1d01626166f2..3263a2556aade3ccef9e2302743da1dac30e9408 100644
--- a/Source/bindings/core/v8/ScriptWrappable.h
+++ b/Source/bindings/core/v8/ScriptWrappable.h
@@ -196,7 +196,7 @@ private:
// class has a corresponding .idl file.
#define DEFINE_WRAPPERTYPEINFO() \
public: \
- virtual const WrapperTypeInfo* wrapperTypeInfo() const override \
+ const WrapperTypeInfo* wrapperTypeInfo() const override \
{ \
return &s_wrapperTypeInfo; \
} \
@@ -214,7 +214,7 @@ private: \
// must not.
#define DEFINE_WRAPPERTYPEINFO_NOT_REACHED() \
public: \
- virtual const WrapperTypeInfo* wrapperTypeInfo() const override \
+ const WrapperTypeInfo* wrapperTypeInfo() const override \
{ \
ASSERT_NOT_REACHED(); \
return 0; \
@@ -235,7 +235,7 @@ private: \
// in X's cpp code, and instantiate X, i.e. "template class X;".
#define DECLARE_WRAPPERTYPEINFO() \
public: \
- virtual const WrapperTypeInfo* wrapperTypeInfo() const override; \
+ const WrapperTypeInfo* wrapperTypeInfo() const override; \
private: \
typedef void end_of_define_wrappertypeinfo_not_reached_t
« no previous file with comments | « Source/bindings/core/v8/ScriptValueSerializer.h ('k') | Source/bindings/core/v8/V8AbstractEventListener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698