Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: Source/bindings/core/v8/ScriptPromiseProperty.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptProfiler.cpp ('k') | Source/bindings/core/v8/ScriptPromisePropertyTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptPromiseProperty.h
diff --git a/Source/bindings/core/v8/ScriptPromiseProperty.h b/Source/bindings/core/v8/ScriptPromiseProperty.h
index f2528d4f11f3983be961f30d55254cf3208fc4e9..4f17e5f6f7d3aa11fa5a29ff1c218520c5605795 100644
--- a/Source/bindings/core/v8/ScriptPromiseProperty.h
+++ b/Source/bindings/core/v8/ScriptPromiseProperty.h
@@ -54,7 +54,7 @@ public:
template<typename PassHolderType>
ScriptPromiseProperty(ExecutionContext*, PassHolderType, Name);
- virtual ~ScriptPromiseProperty() { }
+ ~ScriptPromiseProperty() override { }
template<typename PassResolvedType>
void resolve(PassResolvedType);
@@ -71,9 +71,9 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- virtual v8::Local<v8::Object> holder(v8::Isolate*, v8::Local<v8::Object> creationContext) override;
- virtual v8::Local<v8::Value> resolvedValue(v8::Isolate*, v8::Local<v8::Object> creationContext) override;
- virtual v8::Local<v8::Value> rejectedValue(v8::Isolate*, v8::Local<v8::Object> creationContext) override;
+ v8::Local<v8::Object> holder(v8::Isolate*, v8::Local<v8::Object> creationContext) override;
+ v8::Local<v8::Value> resolvedValue(v8::Isolate*, v8::Local<v8::Object> creationContext) override;
+ v8::Local<v8::Value> rejectedValue(v8::Isolate*, v8::Local<v8::Object> creationContext) override;
HolderType m_holder;
ResolvedType m_resolved;
« no previous file with comments | « Source/bindings/core/v8/ScriptProfiler.cpp ('k') | Source/bindings/core/v8/ScriptPromisePropertyTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698