Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: Source/bindings/templates/callback_interface.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 {% include 'copyright_block.txt' %} 1 {% include 'copyright_block.txt' %}
2 #ifndef {{v8_class}}_h 2 #ifndef {{v8_class}}_h
3 #define {{v8_class}}_h 3 #define {{v8_class}}_h
4 4
5 {% filter conditional(conditional_string) %} 5 {% filter conditional(conditional_string) %}
6 {% for filename in header_includes %} 6 {% for filename in header_includes %}
7 #include "{{filename}}" 7 #include "{{filename}}"
8 {% endfor %} 8 {% endfor %}
9 9
10 namespace blink { 10 namespace blink {
11 11
12 class {{v8_class}} final : public {{cpp_class}}, public ActiveDOMCallback { 12 class {{v8_class}} final : public {{cpp_class}}, public ActiveDOMCallback {
13 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN({{v8_class}}); 13 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN({{v8_class}});
14 public: 14 public:
15 static {{v8_class}}* create(v8::Local<v8::Function> callback, ScriptState* s criptState) 15 static {{v8_class}}* create(v8::Local<v8::Function> callback, ScriptState* s criptState)
16 { 16 {
17 return new {{v8_class}}(callback, scriptState); 17 return new {{v8_class}}(callback, scriptState);
18 } 18 }
19 19
20 virtual ~{{v8_class}}(); 20 ~{{v8_class}}() override;
21 21
22 DECLARE_VIRTUAL_TRACE(); 22 DECLARE_VIRTUAL_TRACE();
23 23
24 {% for method in methods %} 24 {% for method in methods %}
25 virtual {{method.cpp_type}} {{method.name}}({{method.argument_declarations | join(', ')}}) override; 25 {{method.cpp_type}} {{method.name}}({{method.argument_declarations | join(', ')}}) override;
26 {% endfor %} 26 {% endfor %}
27 private: 27 private:
28 {{exported}}{{v8_class}}(v8::Local<v8::Function>, ScriptState*); 28 {{exported}}{{v8_class}}(v8::Local<v8::Function>, ScriptState*);
29 29
30 ScopedPersistent<v8::Function> m_callback; 30 ScopedPersistent<v8::Function> m_callback;
31 RefPtr<ScriptState> m_scriptState; 31 RefPtr<ScriptState> m_scriptState;
32 }; 32 };
33 33
34 } 34 }
35 {% endfilter %} 35 {% endfilter %}
36 #endif // {{v8_class}}_h 36 #endif // {{v8_class}}_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698