Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h

Issue 1236473002: Fix virtual/override/final usage in Source/bindings/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/core/v8/V8BindingForTesting.h ('k') | Source/bindings/core/v8/V8ErrorHandler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 class CustomElementLifecycleCallbacks; 45 class CustomElementLifecycleCallbacks;
46 class Element; 46 class Element;
47 class V8PerContextData; 47 class V8PerContextData;
48 48
49 class V8CustomElementLifecycleCallbacks final : public CustomElementLifecycleCal lbacks, public ContextLifecycleObserver { 49 class V8CustomElementLifecycleCallbacks final : public CustomElementLifecycleCal lbacks, public ContextLifecycleObserver {
50 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(V8CustomElementLifecycleCallbacks); 50 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(V8CustomElementLifecycleCallbacks);
51 public: 51 public:
52 static PassRefPtrWillBeRawPtr<V8CustomElementLifecycleCallbacks> create(Scri ptState*, v8::Local<v8::Object> prototype, v8::MaybeLocal<v8::Function> created, v8::MaybeLocal<v8::Function> attached, v8::MaybeLocal<v8::Function> detached, v 8::MaybeLocal<v8::Function> attributeChanged); 52 static PassRefPtrWillBeRawPtr<V8CustomElementLifecycleCallbacks> create(Scri ptState*, v8::Local<v8::Object> prototype, v8::MaybeLocal<v8::Function> created, v8::MaybeLocal<v8::Function> attached, v8::MaybeLocal<v8::Function> detached, v 8::MaybeLocal<v8::Function> attributeChanged);
53 53
54 virtual ~V8CustomElementLifecycleCallbacks(); 54 ~V8CustomElementLifecycleCallbacks() override;
55 55
56 bool setBinding(CustomElementDefinition* owner, PassOwnPtr<CustomElementBind ing>); 56 bool setBinding(CustomElementDefinition* owner, PassOwnPtr<CustomElementBind ing>);
57 57
58 DECLARE_VIRTUAL_TRACE(); 58 DECLARE_VIRTUAL_TRACE();
59 59
60 private: 60 private:
61 V8CustomElementLifecycleCallbacks(ScriptState*, v8::Local<v8::Object> protot ype, v8::MaybeLocal<v8::Function> created, v8::MaybeLocal<v8::Function> attached , v8::MaybeLocal<v8::Function> detached, v8::MaybeLocal<v8::Function> attributeC hanged); 61 V8CustomElementLifecycleCallbacks(ScriptState*, v8::Local<v8::Object> protot ype, v8::MaybeLocal<v8::Function> created, v8::MaybeLocal<v8::Function> attached , v8::MaybeLocal<v8::Function> detached, v8::MaybeLocal<v8::Function> attributeC hanged);
62 62
63 virtual void created(Element*) override; 63 void created(Element*) override;
64 virtual void attached(Element*) override; 64 void attached(Element*) override;
65 virtual void detached(Element*) override; 65 void detached(Element*) override;
66 virtual void attributeChanged(Element*, const AtomicString& name, const Atom icString& oldValue, const AtomicString& newValue) override; 66 void attributeChanged(Element*, const AtomicString& name, const AtomicString & oldValue, const AtomicString& newValue) override;
67 67
68 void call(const ScopedPersistent<v8::Function>& weakCallback, Element*); 68 void call(const ScopedPersistent<v8::Function>& weakCallback, Element*);
69 69
70 V8PerContextData* creationContextData(); 70 V8PerContextData* creationContextData();
71 71
72 RefPtr<ScriptState> m_scriptState; 72 RefPtr<ScriptState> m_scriptState;
73 ScopedPersistent<v8::Object> m_prototype; 73 ScopedPersistent<v8::Object> m_prototype;
74 ScopedPersistent<v8::Function> m_created; 74 ScopedPersistent<v8::Function> m_created;
75 ScopedPersistent<v8::Function> m_attached; 75 ScopedPersistent<v8::Function> m_attached;
76 ScopedPersistent<v8::Function> m_detached; 76 ScopedPersistent<v8::Function> m_detached;
77 ScopedPersistent<v8::Function> m_attributeChanged; 77 ScopedPersistent<v8::Function> m_attributeChanged;
78 }; 78 };
79 79
80 } 80 }
81 81
82 #endif // V8CustomElementLifecycleCallbacks_h 82 #endif // V8CustomElementLifecycleCallbacks_h
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8BindingForTesting.h ('k') | Source/bindings/core/v8/V8ErrorHandler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698