Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 6811012: Remove some dead code. (Closed)

Created:
9 years, 8 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove some dead code. - virtual-frame* - register-allocator* - jump-target* - most of codegen* - AstOptimizer and fields on AST There is a lot of additional cleanup that we should do but this gets rid of a lot. R=kmillikin@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -39526 lines) Patch
M src/SConscript View 7 chunks +0 lines, -23 lines 0 comments Download
M src/arm/builtins-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/arm/codegen-arm.h View 4 chunks +1 line, -505 lines 0 comments Download
M src/arm/codegen-arm.cc View 3 chunks +2 lines, -7387 lines 0 comments Download
D src/arm/codegen-arm-inl.h View 1 chunk +0 lines, -48 lines 0 comments Download
M src/arm/debug-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/arm/ic-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D src/arm/jump-target-arm.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/arm/register-allocator-arm.h View 1 chunk +0 lines, -44 lines 0 comments Download
D src/arm/register-allocator-arm.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D src/arm/register-allocator-arm-inl.h View 1 chunk +0 lines, -100 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D src/arm/virtual-frame-arm.h View 1 chunk +0 lines, -523 lines 0 comments Download
D src/arm/virtual-frame-arm.cc View 1 chunk +0 lines, -843 lines 0 comments Download
D src/arm/virtual-frame-arm-inl.h View 1 chunk +0 lines, -59 lines 0 comments Download
M src/assembler.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/ast.h View 11 chunks +14 lines, -76 lines 0 comments Download
M src/ast.cc View 5 chunks +3 lines, -10 lines 0 comments Download
M src/ast-inl.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/codegen.h View 4 chunks +1 line, -162 lines 0 comments Download
M src/codegen.cc View 6 chunks +2 lines, -255 lines 0 comments Download
D src/codegen-inl.h View 1 chunk +0 lines, -68 lines 0 comments Download
M src/compiler.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/codegen-ia32.h View 4 chunks +2 lines, -724 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 3 chunks +2 lines, -10122 lines 0 comments Download
D src/ia32/codegen-ia32-inl.h View 1 chunk +0 lines, -46 lines 0 comments Download
M src/ia32/debug-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D src/ia32/jump-target-ia32.cc View 1 chunk +0 lines, -437 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 3 chunks +1 line, -8 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +1 line, -14 lines 0 comments Download
D src/ia32/register-allocator-ia32.h View 1 chunk +0 lines, -43 lines 0 comments Download
D src/ia32/register-allocator-ia32.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D src/ia32/register-allocator-ia32-inl.h View 1 chunk +0 lines, -82 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/ia32/virtual-frame-ia32.h View 1 chunk +0 lines, -650 lines 0 comments Download
D src/ia32/virtual-frame-ia32.cc View 1 chunk +0 lines, -1366 lines 0 comments Download
D src/jump-target.h View 1 chunk +0 lines, -90 lines 0 comments Download
D src/jump-target.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D src/jump-target-heavy.h View 1 chunk +0 lines, -238 lines 0 comments Download
D src/jump-target-heavy.cc View 1 chunk +0 lines, -427 lines 0 comments Download
D src/jump-target-heavy-inl.h View 1 chunk +0 lines, -51 lines 0 comments Download
D src/jump-target-inl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D src/jump-target-light.h View 1 chunk +0 lines, -193 lines 0 comments Download
D src/jump-target-light.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D src/jump-target-light-inl.h View 1 chunk +0 lines, -56 lines 0 comments Download
M src/parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parser.cc View 9 chunks +5 lines, -9 lines 0 comments Download
M src/prettyprinter.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/prettyprinter.cc View 6 chunks +6 lines, -31 lines 0 comments Download
D src/register-allocator.h View 1 chunk +0 lines, -310 lines 0 comments Download
D src/register-allocator.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D src/register-allocator-inl.h View 1 chunk +0 lines, -141 lines 0 comments Download
M src/rewriter.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/rewriter.cc View 3 chunks +1 line, -660 lines 0 comments Download
M src/variables.h View 4 chunks +1 line, -46 lines 0 comments Download
M src/variables.cc View 2 chunks +1 line, -19 lines 0 comments Download
D src/virtual-frame.h View 1 chunk +0 lines, -59 lines 0 comments Download
D src/virtual-frame.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D src/virtual-frame-heavy.cc View 1 chunk +0 lines, -312 lines 0 comments Download
D src/virtual-frame-heavy-inl.h View 1 chunk +0 lines, -190 lines 0 comments Download
D src/virtual-frame-inl.h View 1 chunk +0 lines, -39 lines 0 comments Download
D src/virtual-frame-light.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D src/virtual-frame-light-inl.h View 1 chunk +0 lines, -171 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.h View 2 chunks +0 lines, -677 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +1 line, -8698 lines 0 comments Download
D src/x64/codegen-x64-inl.h View 1 chunk +0 lines, -46 lines 0 comments Download
M src/x64/debug-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/x64/jump-target-x64.cc View 1 chunk +0 lines, -437 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/x64/register-allocator-x64.h View 1 chunk +0 lines, -43 lines 0 comments Download
D src/x64/register-allocator-x64.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D src/x64/register-allocator-x64-inl.h View 1 chunk +0 lines, -87 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/x64/virtual-frame-x64.h View 1 chunk +0 lines, -597 lines 0 comments Download
D src/x64/virtual-frame-x64.cc View 1 chunk +0 lines, -1296 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 8 months ago (2011-04-07 07:13:59 UTC) #1
Kevin Millikin (Chromium)
9 years, 8 months ago (2011-04-07 08:47:01 UTC) #2
LVGTM.

"Learn to enjoy deleting code."

Powered by Google App Engine
This is Rietveld 408576698