Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 6246027: Move src/gfx/ to src/ui/gfx... (Closed)

Created:
9 years, 10 months ago by sail
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), sjl, Alpha Left Google, Sergey Ulanov, ddorwin+watch_chromium.org, dmac, apatrick_chromium, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, awong, garykac, Paweł Hajdan Jr., darin-cc_chromium.org, scherkus (not reviewing), xiyuan
Visibility:
Public.

Description

Move src/gfx/ to src/ui/gfx To reduce the size of this change I've left stub header files in src/gfx/. Once all includes have been updated I'll delete the stub files. BUG=71063 TEST=Still doing test builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73530

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -14626 lines) Patch
M app/app_base.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/all.gyp View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome.gyp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D gfx/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gfx/blit.h View 1 2 1 chunk +2 lines, -43 lines 0 comments Download
D gfx/blit.cc View 1 2 1 chunk +0 lines, -202 lines 0 comments Download
D gfx/blit_unittest.cc View 1 2 1 chunk +0 lines, -135 lines 0 comments Download
M gfx/brush.h View 1 2 1 chunk +2 lines, -14 lines 0 comments Download
M gfx/canvas.h View 1 2 1 chunk +2 lines, -228 lines 0 comments Download
D gfx/canvas.cc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M gfx/canvas_direct2d.h View 1 2 1 chunk +2 lines, -102 lines 0 comments Download
D gfx/canvas_direct2d.cc View 1 2 1 chunk +0 lines, -362 lines 0 comments Download
D gfx/canvas_direct2d_unittest.cc View 1 2 1 chunk +0 lines, -350 lines 0 comments Download
M gfx/canvas_skia.h View 1 2 1 chunk +2 lines, -155 lines 0 comments Download
D gfx/canvas_skia.cc View 1 2 1 chunk +0 lines, -391 lines 0 comments Download
D gfx/canvas_skia_linux.cc View 1 2 1 chunk +0 lines, -387 lines 0 comments Download
D gfx/canvas_skia_mac.mm View 1 2 1 chunk +0 lines, -88 lines 0 comments Download
M gfx/canvas_skia_paint.h View 1 2 1 chunk +2 lines, -11 lines 0 comments Download
D gfx/canvas_skia_win.cc View 1 2 1 chunk +0 lines, -301 lines 0 comments Download
D gfx/codec/DEPS View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D gfx/codec/jpeg_codec.cc View 1 2 1 chunk +0 lines, -535 lines 0 comments Download
D gfx/codec/jpeg_codec_unittest.cc View 1 2 1 chunk +0 lines, -151 lines 0 comments Download
D gfx/codec/png_codec.cc View 1 2 1 chunk +0 lines, -699 lines 0 comments Download
D gfx/codec/png_codec_unittest.cc View 1 2 1 chunk +0 lines, -297 lines 0 comments Download
M gfx/color_utils.h View 1 2 1 chunk +2 lines, -70 lines 0 comments Download
D gfx/color_utils.cc View 1 2 1 chunk +0 lines, -300 lines 0 comments Download
D gfx/color_utils_unittest.cc View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
D gfx/empty.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M gfx/favicon_size.h View 1 2 1 chunk +2 lines, -24 lines 0 comments Download
M gfx/font.h View 1 2 1 chunk +2 lines, -103 lines 0 comments Download
D gfx/font.cc View 1 2 1 chunk +0 lines, -85 lines 0 comments Download
D gfx/font_unittest.cc View 1 2 1 chunk +0 lines, -120 lines 0 comments Download
M gfx/gdi_util.h View 1 2 1 chunk +2 lines, -28 lines 0 comments Download
D gfx/gdi_util.cc View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
D gfx/gfx.gyp View 1 2 1 chunk +0 lines, -231 lines 0 comments Download
M gfx/gfx_module.h View 1 2 1 chunk +2 lines, -24 lines 0 comments Download
D gfx/gfx_module.cc View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
M gfx/gfx_paths.h View 1 2 1 chunk +2 lines, -18 lines 0 comments Download
D gfx/gfx_paths.cc View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
D gfx/gfx_resources.grd View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
M gfx/gtk_native_view_id_manager.h View 1 2 1 chunk +2 lines, -131 lines 0 comments Download
D gfx/gtk_native_view_id_manager.cc View 1 2 1 chunk +0 lines, -223 lines 0 comments Download
M gfx/gtk_preserve_window.h View 1 2 1 chunk +2 lines, -54 lines 0 comments Download
D gfx/gtk_preserve_window.cc View 1 2 1 chunk +0 lines, -200 lines 0 comments Download
M gfx/gtk_util.h View 1 2 1 chunk +2 lines, -74 lines 0 comments Download
D gfx/gtk_util.cc View 1 2 1 chunk +0 lines, -212 lines 0 comments Download
M gfx/icon_util.h View 1 2 1 chunk +2 lines, -184 lines 0 comments Download
D gfx/icon_util.cc View 1 2 1 chunk +0 lines, -457 lines 0 comments Download
D gfx/icon_util_unittest.cc View 1 2 1 chunk +0 lines, -256 lines 0 comments Download
M gfx/insets.h View 1 2 1 chunk +2 lines, -84 lines 0 comments Download
D gfx/insets.cc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D gfx/insets_unittest.cc View 1 2 1 chunk +0 lines, -66 lines 0 comments Download
M gfx/native_theme_linux.h View 1 2 1 chunk +2 lines, -229 lines 0 comments Download
D gfx/native_theme_linux.cc View 1 2 1 chunk +0 lines, -941 lines 0 comments Download
M gfx/native_theme_win.h View 1 2 1 chunk +2 lines, -305 lines 0 comments Download
D gfx/native_theme_win.cc View 1 2 1 chunk +0 lines, -874 lines 0 comments Download
D gfx/native_theme_win_unittest.cc View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M gfx/native_widget_types.h View 1 2 1 chunk +2 lines, -166 lines 0 comments Download
D gfx/native_widget_types_gtk.cc View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M gfx/path.h View 1 2 1 chunk +2 lines, -47 lines 0 comments Download
D gfx/path.cc View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D gfx/path_gtk.cc View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
D gfx/path_win.cc View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
M gfx/platform_font.h View 1 2 1 chunk +2 lines, -68 lines 0 comments Download
M gfx/platform_font_gtk.h View 1 2 1 chunk +2 lines, -97 lines 0 comments Download
D gfx/platform_font_gtk.cc View 1 2 1 chunk +0 lines, -450 lines 0 comments Download
M gfx/platform_font_mac.h View 1 2 1 chunk +2 lines, -47 lines 0 comments Download
D gfx/platform_font_mac.mm View 1 2 1 chunk +0 lines, -143 lines 0 comments Download
M gfx/platform_font_win.h View 1 2 1 chunk +2 lines, -121 lines 0 comments Download
D gfx/platform_font_win.cc View 1 2 1 chunk +0 lines, -269 lines 0 comments Download
M gfx/point.h View 1 2 1 chunk +2 lines, -91 lines 0 comments Download
D gfx/point.cc View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
M gfx/rect.h View 1 2 1 chunk +2 lines, -167 lines 0 comments Download
D gfx/rect.cc View 1 2 1 chunk +0 lines, -256 lines 0 comments Download
D gfx/rect_unittest.cc View 1 2 1 chunk +0 lines, -314 lines 0 comments Download
D gfx/run_all_unittests.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M gfx/scoped_cg_context_state_mac.h View 1 2 1 chunk +2 lines, -21 lines 0 comments Download
M gfx/scoped_image.h View 1 2 1 chunk +2 lines, -137 lines 0 comments Download
D gfx/scoped_image_unittest.cc View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
M gfx/scrollbar_size.h View 1 2 1 chunk +2 lines, -8 lines 0 comments Download
D gfx/scrollbar_size.cc View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M gfx/size.h View 1 2 1 chunk +2 lines, -72 lines 0 comments Download
D gfx/size.cc View 1 2 1 chunk +0 lines, -70 lines 0 comments Download
M gfx/skbitmap_operations.h View 1 2 1 chunk +2 lines, -92 lines 0 comments Download
D gfx/skbitmap_operations.cc View 1 2 1 chunk +0 lines, -721 lines 0 comments Download
D gfx/skbitmap_operations_unittest.cc View 1 2 1 chunk +0 lines, -517 lines 0 comments Download
M gfx/skia_util.h View 1 2 1 chunk +2 lines, -29 lines 0 comments Download
D gfx/skia_util.cc View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
M gfx/skia_utils_gtk.h View 1 2 1 chunk +2 lines, -13 lines 0 comments Download
D gfx/skia_utils_gtk.cc View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
M gfx/test_suite.h View 1 2 1 chunk +2 lines, -14 lines 0 comments Download
D gfx/test_suite.cc View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
M gfx/win_util.h View 1 2 1 chunk +2 lines, -9 lines 0 comments Download
D gfx/win_util.cc View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
M gpu/gpu.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/tools/mfdecoder/README.chromium View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/remoting.gyp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/grit/resource_ids View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/blit.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/blit.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/blit_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/brush.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/canvas.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/canvas.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/canvas_direct2d.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/canvas_direct2d.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/canvas_direct2d_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/canvas_skia.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/canvas_skia.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/canvas_skia_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/canvas_skia_mac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/canvas_skia_paint.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/canvas_skia_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/codec/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/codec/jpeg_codec.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/codec/jpeg_codec.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/codec/jpeg_codec_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/codec/png_codec.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/codec/png_codec.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/codec/png_codec_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/color_utils.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/color_utils.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/color_utils_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/empty.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/favicon_size.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/font.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/font.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/font_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/gdi_util.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/gdi_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/gfx.gyp View 9 chunks +21 lines, -21 lines 0 comments Download
A + ui/gfx/gfx_module.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/gfx_module.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/gfx_paths.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/gfx_paths.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/gfx_resources.grd View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + ui/gfx/gtk_native_view_id_manager.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/gtk_native_view_id_manager.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/gtk_preserve_window.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/gtk_preserve_window.cc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/gtk_util.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/gtk_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/icon_util.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/icon_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/icon_util_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/insets.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/insets.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/insets_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/native_theme_linux.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/native_theme_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/native_theme_win.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/native_theme_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/native_theme_win_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/native_widget_types.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/native_widget_types_gtk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/path.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/path.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/path_gtk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/path_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/platform_font.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/platform_font_gtk.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/platform_font_gtk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/platform_font_mac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/platform_font_mac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/platform_font_win.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/platform_font_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/point.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/point.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/rect.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/rect.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/rect_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/run_all_unittests.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/scoped_cg_context_state_mac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/scoped_image.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/scoped_image_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/scrollbar_size.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/scrollbar_size.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/size.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/size.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/skbitmap_operations.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/skbitmap_operations.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/skbitmap_operations_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/skia_util.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/skia_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/skia_utils_gtk.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/skia_utils_gtk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/test_suite.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/test_suite.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/win_util.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/win_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sail
9 years, 10 months ago (2011-02-01 19:38:12 UTC) #1
sail
Hm.. third_party/WebKit/Source/WebKit/chromium/WebKit.gyp has a reference to gfx/gfx_resources.pak This file is now in ui/gfx/gfx_resources.pak. Is there ...
9 years, 10 months ago (2011-02-01 20:02:06 UTC) #2
sail
This version should be good to go. I changed gfx_resources.grd to produce two .pak files. ...
9 years, 10 months ago (2011-02-01 23:43:01 UTC) #3
Nico
tony, can you take a short look at the gyp changes in webkit? (last 2 ...
9 years, 10 months ago (2011-02-01 23:48:52 UTC) #4
tony
On 2011/02/01 23:48:52, Nico wrote: > tony, can you take a short look at the ...
9 years, 10 months ago (2011-02-02 00:12:17 UTC) #5
tony
(+xiyuan as an FYI since he added the gfx_resources target)
9 years, 10 months ago (2011-02-02 00:13:42 UTC) #6
Ben Goodger (Google)
LGTM http://codereview.chromium.org/6246027/diff/1226/gfx/DEPS File gfx/DEPS (right): http://codereview.chromium.org/6246027/diff/1226/gfx/DEPS#newcode3 gfx/DEPS:3: "+ui/gfx", Sort these lists please
9 years, 10 months ago (2011-02-02 19:02:59 UTC) #7
sail
http://codereview.chromium.org/6246027/diff/1226/gfx/DEPS File gfx/DEPS (right): http://codereview.chromium.org/6246027/diff/1226/gfx/DEPS#newcode3 gfx/DEPS:3: "+ui/gfx", On 2011/02/02 19:02:59, Ben Goodger wrote: > Sort ...
9 years, 10 months ago (2011-02-02 19:10:00 UTC) #8
sail
9 years, 10 months ago (2011-02-02 19:20:16 UTC) #9
Submitting, will working on updating headers next.

Powered by Google App Engine
This is Rietveld 408576698