Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 11244: Move PlatformCanvas and PlatformDevice from base/gfx to webkit/port. I left h... (Closed)

Created:
12 years, 1 month ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move PlatformCanvas and PlatformDevice from base/gfx to webkit/port. I left header files in the original locations that include the ones in the new location so I don't have to change all the includes in Chrome at once. These will be removed later. I kept the names, indenting, and the namespaces the same for now. I will also be cleaning this up in separate passes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5690

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2222 lines, -6573 lines) Patch
M DEPS View 1 1 chunk +5 lines, -1 line 0 comments Download
M base/base_unittests.scons View 2 chunks +0 lines, -2 lines 0 comments Download
M base/build/base_gfx.vcproj View 1 2 3 chunks +0 lines, -28 lines 0 comments Download
M base/build/base_unittests.vcproj View 1 chunk +0 lines, -8 lines 0 comments Download
M base/gfx/base_gfx.scons View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M base/gfx/bitmap_platform_device.h View 1 1 chunk +3 lines, -23 lines 0 comments Download
M base/gfx/bitmap_platform_device_linux.h View 1 1 chunk +3 lines, -82 lines 0 comments Download
D base/gfx/bitmap_platform_device_linux.cc View 1 1 chunk +0 lines, -94 lines 0 comments Download
M base/gfx/bitmap_platform_device_mac.h View 1 1 chunk +3 lines, -85 lines 0 comments Download
D base/gfx/bitmap_platform_device_mac.cc View 1 1 chunk +0 lines, -289 lines 0 comments Download
M base/gfx/bitmap_platform_device_win.h View 1 1 chunk +3 lines, -101 lines 0 comments Download
D base/gfx/bitmap_platform_device_win.cc View 1 1 chunk +0 lines, -446 lines 0 comments Download
M base/gfx/platform_canvas.h View 1 1 chunk +3 lines, -28 lines 0 comments Download
M base/gfx/platform_canvas_linux.h View 1 1 chunk +3 lines, -42 lines 0 comments Download
D base/gfx/platform_canvas_linux.cc View 1 1 chunk +0 lines, -55 lines 0 comments Download
M base/gfx/platform_canvas_mac.h View 1 1 chunk +3 lines, -77 lines 0 comments Download
D base/gfx/platform_canvas_mac.cc View 1 1 chunk +0 lines, -80 lines 0 comments Download
D base/gfx/platform_canvas_unittest.cc View 1 1 chunk +0 lines, -296 lines 0 comments Download
M base/gfx/platform_canvas_win.h View 1 1 chunk +3 lines, -186 lines 0 comments Download
D base/gfx/platform_canvas_win.cc View 1 1 chunk +0 lines, -122 lines 0 comments Download
M base/gfx/platform_device.h View 1 1 chunk +3 lines, -23 lines 0 comments Download
M base/gfx/platform_device_linux.h View 1 1 chunk +3 lines, -16 lines 0 comments Download
D base/gfx/platform_device_linux.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
M base/gfx/platform_device_mac.h View 1 1 chunk +3 lines, -76 lines 0 comments Download
D base/gfx/platform_device_mac.cc View 1 1 chunk +0 lines, -161 lines 0 comments Download
M base/gfx/platform_device_win.h View 1 1 chunk +3 lines, -86 lines 0 comments Download
D base/gfx/platform_device_win.cc View 1 1 chunk +0 lines, -229 lines 0 comments Download
D base/gfx/vector_canvas.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D base/gfx/vector_canvas_unittest.cc View 1 chunk +0 lines, -1008 lines 0 comments Download
M base/gfx/vector_device.h View 1 chunk +3 lines, -115 lines 0 comments Download
D base/gfx/vector_device.cc View 1 chunk +0 lines, -612 lines 0 comments Download
M chrome/chrome.sln View 33 chunks +1970 lines, -1969 lines 0 comments Download
M webkit/SConscript.port View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M webkit/build/port/port.vcproj View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/BitmapPlatformDevice.h View 1 chunk +16 lines, -13 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceLinux.h View 1 4 chunks +13 lines, -8 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceLinux.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceMac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceMac.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceWin.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformCanvas.h View 1 chunk +6 lines, -8 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformCanvasLinux.h View 2 chunks +7 lines, -6 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformCanvasLinux.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformCanvasMac.h View 3 chunks +9 lines, -8 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformCanvasMac.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformCanvasWin.h View 3 chunks +12 lines, -6 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformCanvasWin.cpp View 3 chunks +14 lines, -18 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformCanvas_unittest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformDevice.h View 1 chunk +11 lines, -11 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformDeviceLinux.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformDeviceLinux.cpp View 1 chunk +1 line, -6 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformDeviceMac.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformDeviceMac.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformDeviceWin.h View 2 chunks +5 lines, -3 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/PlatformDeviceWin.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
A webkit/port/platform/graphics/skia/public/README View 1 chunk +3 lines, -0 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/VectorCanvas.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/VectorCanvas.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/VectorCanvas_unittest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/VectorDevice.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/port/platform/graphics/skia/public/VectorDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/SConscript View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_tests.vcproj View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
darin (slow to review)
12 years, 1 month ago (2008-11-18 20:54:56 UTC) #1
LGTM

Powered by Google App Engine
This is Rietveld 408576698