Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
danakj
CC:
asvitkine+watch_chromium.org, chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org, gavinp+memory_chromium.org, Ilya Sherman, sadrul, tfarina, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in base/ BUG=417463 TBR=danakj@chromium.org Committed: https://crrev.com/5648818ef9d5ef5fda79cd5dde2e42567af07785 Cr-Commit-Position: refs/heads/master@{#300447}

Patch Set 1 #

Patch Set 2 : Formatted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+651 lines, -740 lines) Patch
M base/async_socket_io_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/bind_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/debug/stack_trace_posix.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M base/debug/trace_event_argument.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event_impl.cc View 1 14 chunks +28 lines, -35 lines 0 comments Download
M base/debug/trace_event_memory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event_memory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event_synthetic_delay.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_synthetic_delay_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_system_stats_monitor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event_system_stats_monitor.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/deferred_sequenced_task_runner.h View 1 2 chunks +8 lines, -9 lines 0 comments Download
M base/environment.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M base/file_version_info_mac.h View 1 chunk +17 lines, -17 lines 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/files/file_path_watcher_fsevents.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M base/files/file_path_watcher_fsevents.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_kqueue.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M base/files/file_path_watcher_mac.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M base/files/important_file_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_file_value_serializer.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M base/json/json_parser.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download
M base/json/json_string_value_serializer.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M base/lazy_instance_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/libdispatch_task_runner.h View 1 2 chunks +8 lines, -9 lines 0 comments Download
M base/memory/discardable_memory_emulated.h View 2 chunks +7 lines, -7 lines 0 comments Download
M base/memory/discardable_memory_mach.h View 1 chunk +7 lines, -7 lines 0 comments Download
M base/memory/discardable_memory_manager_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M base/memory/linked_ptr_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M base/memory/ref_counted_memory.h View 4 chunks +12 lines, -12 lines 0 comments Download
M base/memory/scoped_ptr_unittest.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M base/memory/scoped_vector_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/memory/weak_ptr_unittest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M base/message_loop/message_loop.h View 2 chunks +4 lines, -4 lines 0 comments Download
M base/message_loop/message_loop_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop_proxy_impl.h View 1 1 chunk +8 lines, -9 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/message_loop/message_pump_default.h View 1 chunk +5 lines, -5 lines 0 comments Download
M base/message_loop/message_pump_libevent.h View 2 chunks +5 lines, -5 lines 0 comments Download
M base/message_loop/message_pump_libevent_unittest.cc View 1 5 chunks +13 lines, -19 lines 0 comments Download
M base/message_loop/message_pump_mac.h View 5 chunks +17 lines, -17 lines 0 comments Download
M base/message_loop/message_pump_perftest.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M base/metrics/field_trial_unittest.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M base/metrics/histogram.h View 1 10 chunks +26 lines, -27 lines 0 comments Download
M base/metrics/histogram_delta_serialization.h View 1 2 chunks +6 lines, -7 lines 0 comments Download
M base/metrics/histogram_samples.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M base/metrics/histogram_snapshot_manager_unittest.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M base/metrics/sample_map.h View 1 2 chunks +14 lines, -14 lines 0 comments Download
M base/metrics/sample_vector.h View 1 2 chunks +14 lines, -15 lines 0 comments Download
M base/metrics/sparse_histogram.h View 1 2 chunks +16 lines, -17 lines 0 comments Download
M base/metrics/stats_counters.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/metrics/stats_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/observer_list_unittest.cc View 1 8 chunks +14 lines, -23 lines 0 comments Download
M base/posix/file_descriptor_shuffle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/posix/file_descriptor_shuffle_unittest.cc View 1 2 chunks +6 lines, -12 lines 0 comments Download
M base/power_monitor/power_monitor_device_source.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/prefs/default_pref_store.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M base/prefs/default_pref_store_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/prefs/json_pref_store.h View 1 3 chunks +18 lines, -20 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/prefs/overlay_user_pref_store.h View 1 1 chunk +19 lines, -21 lines 0 comments Download
M base/prefs/persistent_pref_store.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_change_registrar.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/prefs/pref_member.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/prefs/pref_notifier_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/prefs/pref_registry_simple.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_store_observer_mock.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/prefs/pref_value_store.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/prefs/testing_pref_service.h View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/testing_pref_store.h View 1 2 chunks +17 lines, -19 lines 0 comments Download
M base/prefs/value_map_pref_store.h View 1 1 chunk +11 lines, -13 lines 0 comments Download
M base/prefs/writeable_pref_store.h View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_iterator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/sequenced_task_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M base/single_thread_task_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M base/supports_user_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sync_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/sync_socket_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/synchronization/condition_variable_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/synchronization/lock_unittest.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M base/synchronization/waitable_event_posix.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M base/synchronization/waitable_event_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/waitable_event_watcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/synchronization/waitable_event_watcher_posix.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M base/task_runner.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/expectations/parser_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 1 3 chunks +7 lines, -8 lines 0 comments Download
M base/test/null_task_runner.h View 1 1 chunk +8 lines, -9 lines 0 comments Download
M base/test/perf_test_suite.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/power_monitor_test_base.h View 2 chunks +6 lines, -6 lines 0 comments Download
M base/test/sequenced_worker_pool_owner.h View 2 chunks +4 lines, -4 lines 0 comments Download
M base/test/simple_test_clock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/simple_test_tick_clock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_simple_task_runner.h View 1 2 chunks +8 lines, -9 lines 0 comments Download
M base/threading/non_thread_safe_unittest.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M base/threading/platform_thread_unittest.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M base/threading/sequenced_worker_pool.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 3 chunks +15 lines, -16 lines 0 comments Download
M base/threading/simple_thread.h View 1 5 chunks +7 lines, -6 lines 0 comments Download
M base/threading/simple_thread_unittest.cc View 1 4 chunks +6 lines, -10 lines 0 comments Download
M base/threading/thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/thread_checker_unittest.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M base/threading/thread_collision_warner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/threading/thread_collision_warner_unittest.cc View 1 5 chunks +6 lines, -8 lines 0 comments Download
M base/threading/thread_local_storage_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/threading/thread_local_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M base/threading/thread_perftest.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M base/threading/thread_unittest.cc View 1 3 chunks +6 lines, -14 lines 0 comments Download
M base/threading/watchdog.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M base/threading/watchdog_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/threading/worker_pool.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M base/threading/worker_pool_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/time/default_clock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/time/default_tick_clock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/timer/hi_res_timer_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/timer/mock_timer.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M base/tools_sanity_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/values.h View 1 8 chunks +25 lines, -26 lines 0 comments Download
M base/values_unittest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668783004/20001
6 years, 2 months ago (2014-10-21 08:47:35 UTC) #3
dcheng
6 years, 2 months ago (2014-10-21 08:55:30 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 10:55:03 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5648818ef9d5ef5fda79cd5dde2e42567af07785 Cr-Commit-Position: refs/heads/master@{#300447}
6 years, 2 months ago (2014-10-21 10:55:48 UTC) #6
danakj
6 years, 2 months ago (2014-10-22 15:03:03 UTC) #7
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698