Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2066)

Unified Diff: base/threading/thread_collision_warner_unittest.cc

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/thread_collision_warner.h ('k') | base/threading/thread_local_storage_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/thread_collision_warner_unittest.cc
diff --git a/base/threading/thread_collision_warner_unittest.cc b/base/threading/thread_collision_warner_unittest.cc
index c7c7d0acf20054c2d4d710d8ef1f808476e0124c..26faff404f6593a89125707ed50490e66b54d717 100644
--- a/base/threading/thread_collision_warner_unittest.cc
+++ b/base/threading/thread_collision_warner_unittest.cc
@@ -41,11 +41,9 @@ class AssertReporter : public base::AsserterBase {
AssertReporter()
: failed_(false) {}
- virtual void warn() override {
- failed_ = true;
- }
+ void warn() override { failed_ = true; }
- virtual ~AssertReporter() {}
+ ~AssertReporter() override {}
bool fail_state() const { return failed_; }
void reset() { failed_ = false; }
@@ -151,7 +149,7 @@ TEST(ThreadCollisionTest, MTBookCriticalSectionTest) {
explicit QueueUser(NonThreadSafeQueue& queue)
: queue_(queue) {}
- virtual void Run() override {
+ void Run() override {
queue_.push(0);
queue_.pop();
}
@@ -209,7 +207,7 @@ TEST(ThreadCollisionTest, MTScopedBookCriticalSectionTest) {
explicit QueueUser(NonThreadSafeQueue& queue)
: queue_(queue) {}
- virtual void Run() override {
+ void Run() override {
queue_.push(0);
queue_.pop();
}
@@ -270,7 +268,7 @@ TEST(ThreadCollisionTest, MTSynchedScopedBookCriticalSectionTest) {
: queue_(queue),
lock_(lock) {}
- virtual void Run() override {
+ void Run() override {
{
base::AutoLock auto_lock(lock_);
queue_.push(0);
@@ -344,7 +342,7 @@ TEST(ThreadCollisionTest, MTSynchedScopedRecursiveBookCriticalSectionTest) {
: queue_(queue),
lock_(lock) {}
- virtual void Run() override {
+ void Run() override {
{
base::AutoLock auto_lock(lock_);
queue_.push(0);
« no previous file with comments | « base/threading/thread_collision_warner.h ('k') | base/threading/thread_local_storage_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698