base/memory/weak_ptr_unittest.cc - Issue 668783004: Standardize usage of virtual/override/final in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/weak_ptr_unittest.cc

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/memory/weak_ptr_unittest.cc

diff --git a/base/memory/weak_ptr_unittest.cc b/base/memory/weak_ptr_unittest.cc

index d79e8d4d41c49d32d4643e24511c139a65d97d2e..d89a5c6bbda66d9417d05ef94d68eb4a6128e31b 100644

--- a/base/memory/weak_ptr_unittest.cc

+++ b/base/memory/weak_ptr_unittest.cc

@@ -62,9 +62,7 @@ class BackgroundThread : public Thread {

public:

BackgroundThread() : Thread("owner_thread") {}

- virtual ~BackgroundThread() {

- Stop();

- }

+ ~BackgroundThread() override { Stop(); }

void CreateArrowFromTarget(Arrow** arrow, Target* target) {

WaitableEvent completion(true, false);

« no previous file with comments | « base/memory/shared_memory_unittest.cc ('k') | base/message_loop/message_loop.h » ('j') | no next file with comments »