Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: base/metrics/histogram_delta_serialization.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/histogram.h ('k') | base/metrics/histogram_samples.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram_delta_serialization.h
diff --git a/base/metrics/histogram_delta_serialization.h b/base/metrics/histogram_delta_serialization.h
index 037d0b596d5c25216ac107d9a00cfc11378f23c7..a379914c0db48c23be5c910330c026a507431145 100644
--- a/base/metrics/histogram_delta_serialization.h
+++ b/base/metrics/histogram_delta_serialization.h
@@ -23,7 +23,7 @@ class BASE_EXPORT HistogramDeltaSerialization : public HistogramFlattener {
public:
// |caller_name| is string used in histograms for counting inconsistencies.
explicit HistogramDeltaSerialization(const std::string& caller_name);
- virtual ~HistogramDeltaSerialization();
+ ~HistogramDeltaSerialization() override;
// Computes deltas in histogram bucket counts relative to the previous call to
// this method. Stores the deltas in serialized form into |serialized_deltas|.
@@ -38,13 +38,12 @@ class BASE_EXPORT HistogramDeltaSerialization : public HistogramFlattener {
private:
// HistogramFlattener implementation.
- virtual void RecordDelta(const HistogramBase& histogram,
- const HistogramSamples& snapshot) override;
- virtual void InconsistencyDetected(
+ void RecordDelta(const HistogramBase& histogram,
+ const HistogramSamples& snapshot) override;
+ void InconsistencyDetected(HistogramBase::Inconsistency problem) override;
+ void UniqueInconsistencyDetected(
HistogramBase::Inconsistency problem) override;
- virtual void UniqueInconsistencyDetected(
- HistogramBase::Inconsistency problem) override;
- virtual void InconsistencyDetectedInLoggedCount(int amount) override;
+ void InconsistencyDetectedInLoggedCount(int amount) override;
// Calculates deltas in histogram counters.
HistogramSnapshotManager histogram_snapshot_manager_;
« no previous file with comments | « base/metrics/histogram.h ('k') | base/metrics/histogram_samples.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698