base/threading/thread_collision_warner.h - Issue 668783004: Standardize usage of virtual/override/final in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/thread_collision_warner.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/threading/thread_collision_warner.h

diff --git a/base/threading/thread_collision_warner.h b/base/threading/thread_collision_warner.h

index 0523c91e38f2bf2eb80041a0d1697034989c15c2..de4e9c3eb58f769f03a29117ffc2e59dab58e5aa 100644

--- a/base/threading/thread_collision_warner.h

+++ b/base/threading/thread_collision_warner.h

@@ -138,8 +138,8 @@ struct BASE_EXPORT AsserterBase {

};

struct BASE_EXPORT DCheckAsserter : public AsserterBase {

- virtual ~DCheckAsserter() {}

- virtual void warn() override;

+ ~DCheckAsserter() override {}

+ void warn() override;

};

class BASE_EXPORT ThreadCollisionWarner {

« no previous file with comments | « base/threading/thread_checker_unittest.cc ('k') | base/threading/thread_collision_warner_unittest.cc » ('j') | no next file with comments »