Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: base/metrics/sample_map.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/histogram_snapshot_manager_unittest.cc ('k') | base/metrics/sample_vector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/sample_map.h
diff --git a/base/metrics/sample_map.h b/base/metrics/sample_map.h
index 0972acd402cb808b03ad7f876a67e9695833e4b8..7a780ea4fe37fff9a424aa86a99cceabb22e98b6 100644
--- a/base/metrics/sample_map.h
+++ b/base/metrics/sample_map.h
@@ -20,18 +20,17 @@ namespace base {
class BASE_EXPORT_PRIVATE SampleMap : public HistogramSamples {
public:
SampleMap();
- virtual ~SampleMap();
+ ~SampleMap() override;
// HistogramSamples implementation:
- virtual void Accumulate(HistogramBase::Sample value,
- HistogramBase::Count count) override;
- virtual HistogramBase::Count GetCount(
- HistogramBase::Sample value) const override;
- virtual HistogramBase::Count TotalCount() const override;
- virtual scoped_ptr<SampleCountIterator> Iterator() const override;
+ void Accumulate(HistogramBase::Sample value,
+ HistogramBase::Count count) override;
+ HistogramBase::Count GetCount(HistogramBase::Sample value) const override;
+ HistogramBase::Count TotalCount() const override;
+ scoped_ptr<SampleCountIterator> Iterator() const override;
protected:
- virtual bool AddSubtractImpl(
+ bool AddSubtractImpl(
SampleCountIterator* iter,
HistogramSamples::Operator op) override; // |op| is ADD or SUBTRACT.
@@ -47,14 +46,15 @@ class BASE_EXPORT_PRIVATE SampleMapIterator : public SampleCountIterator {
SampleToCountMap;
explicit SampleMapIterator(const SampleToCountMap& sample_counts);
- virtual ~SampleMapIterator();
+ ~SampleMapIterator() override;
// SampleCountIterator implementation:
- virtual bool Done() const override;
- virtual void Next() override;
- virtual void Get(HistogramBase::Sample* min,
- HistogramBase::Sample* max,
- HistogramBase::Count* count) const override;
+ bool Done() const override;
+ void Next() override;
+ void Get(HistogramBase::Sample* min,
+ HistogramBase::Sample* max,
+ HistogramBase::Count* count) const override;
+
private:
SampleToCountMap::const_iterator iter_;
const SampleToCountMap::const_iterator end_;
« no previous file with comments | « base/metrics/histogram_snapshot_manager_unittest.cc ('k') | base/metrics/sample_vector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698