Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: base/memory/ref_counted_memory.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/linked_ptr_unittest.cc ('k') | base/memory/scoped_ptr_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/ref_counted_memory.h
diff --git a/base/memory/ref_counted_memory.h b/base/memory/ref_counted_memory.h
index f7acc65d1f9662a004a73c90e6dad81dbf887d60..66dc65ff425cfd7f34dfba2a372ab5ef974fa3b5 100644
--- a/base/memory/ref_counted_memory.h
+++ b/base/memory/ref_counted_memory.h
@@ -52,11 +52,11 @@ class BASE_EXPORT RefCountedStaticMemory : public RefCountedMemory {
length_(length) {}
// Overridden from RefCountedMemory:
- virtual const unsigned char* front() const override;
- virtual size_t size() const override;
+ const unsigned char* front() const override;
+ size_t size() const override;
private:
- virtual ~RefCountedStaticMemory();
+ ~RefCountedStaticMemory() override;
const unsigned char* data_;
size_t length_;
@@ -81,14 +81,14 @@ class BASE_EXPORT RefCountedBytes : public RefCountedMemory {
static RefCountedBytes* TakeVector(std::vector<unsigned char>* to_destroy);
// Overridden from RefCountedMemory:
- virtual const unsigned char* front() const override;
- virtual size_t size() const override;
+ const unsigned char* front() const override;
+ size_t size() const override;
const std::vector<unsigned char>& data() const { return data_; }
std::vector<unsigned char>& data() { return data_; }
private:
- virtual ~RefCountedBytes();
+ ~RefCountedBytes() override;
std::vector<unsigned char> data_;
@@ -107,14 +107,14 @@ class BASE_EXPORT RefCountedString : public RefCountedMemory {
static RefCountedString* TakeString(std::string* to_destroy);
// Overridden from RefCountedMemory:
- virtual const unsigned char* front() const override;
- virtual size_t size() const override;
+ const unsigned char* front() const override;
+ size_t size() const override;
const std::string& data() const { return data_; }
std::string& data() { return data_; }
private:
- virtual ~RefCountedString();
+ ~RefCountedString() override;
std::string data_;
@@ -129,11 +129,11 @@ class BASE_EXPORT RefCountedMallocedMemory : public base::RefCountedMemory {
RefCountedMallocedMemory(void* data, size_t length);
// Overridden from RefCountedMemory:
- virtual const unsigned char* front() const override;
- virtual size_t size() const override;
+ const unsigned char* front() const override;
+ size_t size() const override;
private:
- virtual ~RefCountedMallocedMemory();
+ ~RefCountedMallocedMemory() override;
unsigned char* data_;
size_t length_;
« no previous file with comments | « base/memory/linked_ptr_unittest.cc ('k') | base/memory/scoped_ptr_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698