base/prefs/pref_member.h - Issue 668783004: Standardize usage of virtual/override/final in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_member.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/prefs/pref_member.h

diff --git a/base/prefs/pref_member.h b/base/prefs/pref_member.h

index fc277930a5f9be686fe62a5a4f6c7a0fba8d7c6c..a05d60ed36c25425f0acf6f202d8f6874eef3a70 100644

--- a/base/prefs/pref_member.h

+++ b/base/prefs/pref_member.h

@@ -116,8 +116,8 @@ class BASE_PREFS_EXPORT PrefMemberBase : public PrefObserver {

const scoped_refptr<base::SingleThreadTaskRunner>& task_runner);

// PrefObserver

- virtual void OnPreferenceChanged(PrefService* service,

- const std::string& pref_name) override;

+ void OnPreferenceChanged(PrefService* service,

+ const std::string& pref_name) override;

void VerifyValuePrefName() const {

DCHECK(!pref_name_.empty());

« no previous file with comments | « base/prefs/pref_change_registrar.h ('k') | base/prefs/pref_notifier_impl.h » ('j') | no next file with comments »