Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: base/threading/simple_thread.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/sequenced_worker_pool.cc ('k') | base/threading/simple_thread_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/simple_thread.h
diff --git a/base/threading/simple_thread.h b/base/threading/simple_thread.h
index e734c291bdc03f23039ab00cee348e01c4e59b30..ecd360405f1348bf899d05f61fca50a9fa0e0db0 100644
--- a/base/threading/simple_thread.h
+++ b/base/threading/simple_thread.h
@@ -78,7 +78,7 @@ class BASE_EXPORT SimpleThread : public PlatformThread::Delegate {
explicit SimpleThread(const std::string& name_prefix);
SimpleThread(const std::string& name_prefix, const Options& options);
- virtual ~SimpleThread();
+ ~SimpleThread() override;
virtual void Start();
virtual void Join();
@@ -102,7 +102,7 @@ class BASE_EXPORT SimpleThread : public PlatformThread::Delegate {
bool HasBeenJoined() { return joined_; }
// Overridden from PlatformThread::Delegate:
- virtual void ThreadMain() override;
+ void ThreadMain() override;
// Only set priorities with a careful understanding of the consequences.
// This is meant for very limited use cases.
@@ -135,8 +135,9 @@ class BASE_EXPORT DelegateSimpleThread : public SimpleThread {
const std::string& name_prefix,
const Options& options);
- virtual ~DelegateSimpleThread();
- virtual void Run() override;
+ ~DelegateSimpleThread() override;
+ void Run() override;
+
private:
Delegate* delegate_;
};
@@ -156,7 +157,7 @@ class BASE_EXPORT DelegateSimpleThreadPool
typedef DelegateSimpleThread::Delegate Delegate;
DelegateSimpleThreadPool(const std::string& name_prefix, int num_threads);
- virtual ~DelegateSimpleThreadPool();
+ ~DelegateSimpleThreadPool() override;
// Start up all of the underlying threads, and start processing work if we
// have any.
@@ -174,7 +175,7 @@ class BASE_EXPORT DelegateSimpleThreadPool
}
// We implement the Delegate interface, for running our internal threads.
- virtual void Run() override;
+ void Run() override;
private:
const std::string name_prefix_;
« no previous file with comments | « base/threading/sequenced_worker_pool.cc ('k') | base/threading/simple_thread_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698