base/synchronization/waitable_event_watcher.h - Issue 668783004: Standardize usage of virtual/override/final in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/waitable_event_watcher.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/synchronization/waitable_event_watcher.h

diff --git a/base/synchronization/waitable_event_watcher.h b/base/synchronization/waitable_event_watcher.h

index 4d2f9b589298ec9050a55f9804d2cf84c012d35b..d4d8e7779bd9d39825d3f69666cfee3d00cf9cca 100644

--- a/base/synchronization/waitable_event_watcher.h

+++ b/base/synchronization/waitable_event_watcher.h

@@ -67,7 +67,7 @@ class BASE_EXPORT WaitableEventWatcher

public:

typedef Callback<void(WaitableEvent*)> EventCallback;

WaitableEventWatcher();

- virtual ~WaitableEventWatcher();

+ ~WaitableEventWatcher() override;

// When @event is signaled, the given callback is called on the thread of the

// current message loop when StartWatching is called.

@@ -96,7 +96,7 @@ class BASE_EXPORT WaitableEventWatcher

win::ObjectWatcher watcher_;

#else

// Implementation of MessageLoop::DestructionObserver

- virtual void WillDestroyCurrentMessageLoop() override;

+ void WillDestroyCurrentMessageLoop() override;

MessageLoop* message_loop_;

scoped_refptr<Flag> cancel_flag_;

« no previous file with comments | « base/synchronization/waitable_event_unittest.cc ('k') | base/synchronization/waitable_event_watcher_posix.cc » ('j') | no next file with comments »