base/values_unittest.cc - Issue 668783004: Standardize usage of virtual/override/final in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values_unittest.cc

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/values_unittest.cc

diff --git a/base/values_unittest.cc b/base/values_unittest.cc

index c8a6cbf9a7735ba3b501c981720d69107c3ddf5b..cbb07f3199daf4646400b10d110b6cac66d45822 100644

--- a/base/values_unittest.cc

+++ b/base/values_unittest.cc

@@ -177,9 +177,7 @@ class DeletionTestValue : public Value {

*deletion_flag_ = false;

}

- virtual ~DeletionTestValue() {

- *deletion_flag_ = true;

- }

+ ~DeletionTestValue() override { *deletion_flag_ = true; }

private:

bool* deletion_flag_;

« no previous file with comments | « base/values.h ('k') | no next file » | no next file with comments »