base/prefs/pref_notifier_impl.h - Issue 668783004: Standardize usage of virtual/override/final in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_notifier_impl.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/prefs/pref_notifier_impl.h

diff --git a/base/prefs/pref_notifier_impl.h b/base/prefs/pref_notifier_impl.h

index 1aa243f64beec2d357a3a88adbe8c8fd712ec899..3f4c254c416a6ec803028f9fe4304f6dbbb671c3 100644

--- a/base/prefs/pref_notifier_impl.h

+++ b/base/prefs/pref_notifier_impl.h

@@ -25,7 +25,7 @@ class BASE_PREFS_EXPORT PrefNotifierImpl

public:

PrefNotifierImpl();

explicit PrefNotifierImpl(PrefService* pref_service);

- virtual ~PrefNotifierImpl();

+ ~PrefNotifierImpl() override;

// If the pref at the given path changes, we call the observer's

// OnPreferenceChanged method.

@@ -41,8 +41,8 @@ class BASE_PREFS_EXPORT PrefNotifierImpl

protected:

// PrefNotifier overrides.

- virtual void OnPreferenceChanged(const std::string& pref_name) override;

- virtual void OnInitializationCompleted(bool succeeded) override;

+ void OnPreferenceChanged(const std::string& pref_name) override;

+ void OnInitializationCompleted(bool succeeded) override;

// A map from pref names to a list of observers. Observers get fired in the

// order they are added. These should only be accessed externally for unit

« no previous file with comments | « base/prefs/pref_member.h ('k') | base/prefs/pref_registry_simple.h » ('j') | no next file with comments »