base/prefs/pref_service.cc - Issue 668783004: Standardize usage of virtual/override/final in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_service.cc

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/prefs/pref_service.cc

diff --git a/base/prefs/pref_service.cc b/base/prefs/pref_service.cc

index bc86ac17399847ccb879cf20cbd7ca26b5b4f71e..433f8145ec2ae923e941a904ffca86032f3651c0 100644

--- a/base/prefs/pref_service.cc

+++ b/base/prefs/pref_service.cc

@@ -28,7 +28,7 @@ class ReadErrorHandler : public PersistentPrefStore::ReadErrorDelegate {

ReadErrorHandler(base::Callback<void(PersistentPrefStore::PrefReadError)> cb)

: callback_(cb) {}

- virtual void OnError(PersistentPrefStore::PrefReadError error) override {

+ void OnError(PersistentPrefStore::PrefReadError error) override {

callback_.Run(error);

}

« no previous file with comments | « base/prefs/pref_registry_simple.h ('k') | base/prefs/pref_store_observer_mock.h » ('j') | no next file with comments »