base/synchronization/condition_variable_unittest.cc - Issue 668783004: Standardize usage of virtual/override/final in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/condition_variable_unittest.cc

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/synchronization/condition_variable_unittest.cc

diff --git a/base/synchronization/condition_variable_unittest.cc b/base/synchronization/condition_variable_unittest.cc

index 4232734a20d8dec897bba697b103f43848054b55..5d7a0ab8b601187629720b06464086a8485a69d7 100644

--- a/base/synchronization/condition_variable_unittest.cc

+++ b/base/synchronization/condition_variable_unittest.cc

@@ -64,10 +64,10 @@ class ConditionVariableTest : public PlatformTest {

class WorkQueue : public PlatformThread::Delegate {

public:

explicit WorkQueue(int thread_count);

- virtual ~WorkQueue();

+ ~WorkQueue() override;

// PlatformThread::Delegate interface.

- virtual void ThreadMain() override;

+ void ThreadMain() override;

//----------------------------------------------------------------------------

// Worker threads only call the following methods.

« no previous file with comments | « base/sync_socket_unittest.cc ('k') | base/synchronization/lock_unittest.cc » ('j') | no next file with comments »