Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: base/prefs/testing_pref_store.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/testing_pref_service.h ('k') | base/prefs/value_map_pref_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/testing_pref_store.h
diff --git a/base/prefs/testing_pref_store.h b/base/prefs/testing_pref_store.h
index aa2bd801eb96c2c880e7cf19d449e0b14ced707b..866b4aeb029c6a5aaf64e5e4401f58535f731c82 100644
--- a/base/prefs/testing_pref_store.h
+++ b/base/prefs/testing_pref_store.h
@@ -21,26 +21,24 @@ class TestingPrefStore : public PersistentPrefStore {
TestingPrefStore();
// Overriden from PrefStore.
- virtual bool GetValue(const std::string& key,
- const base::Value** result) const override;
- virtual void AddObserver(PrefStore::Observer* observer) override;
- virtual void RemoveObserver(PrefStore::Observer* observer) override;
- virtual bool HasObservers() const override;
- virtual bool IsInitializationComplete() const override;
+ bool GetValue(const std::string& key,
+ const base::Value** result) const override;
+ void AddObserver(PrefStore::Observer* observer) override;
+ void RemoveObserver(PrefStore::Observer* observer) override;
+ bool HasObservers() const override;
+ bool IsInitializationComplete() const override;
// PersistentPrefStore overrides:
- virtual bool GetMutableValue(const std::string& key,
- base::Value** result) override;
- virtual void ReportValueChanged(const std::string& key) override;
- virtual void SetValue(const std::string& key, base::Value* value) override;
- virtual void SetValueSilently(const std::string& key,
- base::Value* value) override;
- virtual void RemoveValue(const std::string& key) override;
- virtual bool ReadOnly() const override;
- virtual PrefReadError GetReadError() const override;
- virtual PersistentPrefStore::PrefReadError ReadPrefs() override;
- virtual void ReadPrefsAsync(ReadErrorDelegate* error_delegate) override;
- virtual void CommitPendingWrite() override;
+ bool GetMutableValue(const std::string& key, base::Value** result) override;
+ void ReportValueChanged(const std::string& key) override;
+ void SetValue(const std::string& key, base::Value* value) override;
+ void SetValueSilently(const std::string& key, base::Value* value) override;
+ void RemoveValue(const std::string& key) override;
+ bool ReadOnly() const override;
+ PrefReadError GetReadError() const override;
+ PersistentPrefStore::PrefReadError ReadPrefs() override;
+ void ReadPrefsAsync(ReadErrorDelegate* error_delegate) override;
+ void CommitPendingWrite() override;
// Marks the store as having completed initialization.
void SetInitializationCompleted();
@@ -72,7 +70,7 @@ class TestingPrefStore : public PersistentPrefStore {
bool committed() { return committed_; }
protected:
- virtual ~TestingPrefStore();
+ ~TestingPrefStore() override;
private:
// Stores the preference values.
« no previous file with comments | « base/prefs/testing_pref_service.h ('k') | base/prefs/value_map_pref_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698