Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2446)

Unified Diff: base/metrics/sparse_histogram.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/sample_vector.h ('k') | base/metrics/stats_counters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/sparse_histogram.h
diff --git a/base/metrics/sparse_histogram.h b/base/metrics/sparse_histogram.h
index 321c6302af13867b05063387785ad3d5a876d2fc..8c056133004032929cc54be0d102d9db922dcd32 100644
--- a/base/metrics/sparse_histogram.h
+++ b/base/metrics/sparse_histogram.h
@@ -34,24 +34,23 @@ class BASE_EXPORT_PRIVATE SparseHistogram : public HistogramBase {
// new one.
static HistogramBase* FactoryGet(const std::string& name, int32 flags);
- virtual ~SparseHistogram();
+ ~SparseHistogram() override;
// HistogramBase implementation:
- virtual HistogramType GetHistogramType() const override;
- virtual bool HasConstructionArguments(
- Sample expected_minimum,
- Sample expected_maximum,
- size_t expected_bucket_count) const override;
- virtual void Add(Sample value) override;
- virtual void AddSamples(const HistogramSamples& samples) override;
- virtual bool AddSamplesFromPickle(PickleIterator* iter) override;
- virtual scoped_ptr<HistogramSamples> SnapshotSamples() const override;
- virtual void WriteHTMLGraph(std::string* output) const override;
- virtual void WriteAscii(std::string* output) const override;
+ HistogramType GetHistogramType() const override;
+ bool HasConstructionArguments(Sample expected_minimum,
+ Sample expected_maximum,
+ size_t expected_bucket_count) const override;
+ void Add(Sample value) override;
+ void AddSamples(const HistogramSamples& samples) override;
+ bool AddSamplesFromPickle(PickleIterator* iter) override;
+ scoped_ptr<HistogramSamples> SnapshotSamples() const override;
+ void WriteHTMLGraph(std::string* output) const override;
+ void WriteAscii(std::string* output) const override;
protected:
// HistogramBase implementation:
- virtual bool SerializeInfoImpl(Pickle* pickle) const override;
+ bool SerializeInfoImpl(Pickle* pickle) const override;
private:
// Clients should always use FactoryGet to create SparseHistogram.
@@ -61,10 +60,10 @@ class BASE_EXPORT_PRIVATE SparseHistogram : public HistogramBase {
PickleIterator* iter);
static HistogramBase* DeserializeInfoImpl(PickleIterator* iter);
- virtual void GetParameters(DictionaryValue* params) const override;
- virtual void GetCountAndBucketData(Count* count,
- int64* sum,
- ListValue* buckets) const override;
+ void GetParameters(DictionaryValue* params) const override;
+ void GetCountAndBucketData(Count* count,
+ int64* sum,
+ ListValue* buckets) const override;
// Helpers for emitting Ascii graphic. Each method appends data to output.
void WriteAsciiImpl(bool graph_it,
« no previous file with comments | « base/metrics/sample_vector.h ('k') | base/metrics/stats_counters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698