base/debug/trace_event_argument.h - Issue 668783004: Standardize usage of virtual/override/final in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/trace_event_argument.h

Issue 668783004: Standardize usage of virtual/override/final in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/debug/trace_event_argument.h

diff --git a/base/debug/trace_event_argument.h b/base/debug/trace_event_argument.h

index 7aa7c87b86a1e095179a51c19174c6d5f4f1daad..98f1bcf2fc90ca2c9ff97a382f014bd32acad4a5 100644

--- a/base/debug/trace_event_argument.h

+++ b/base/debug/trace_event_argument.h

@@ -40,10 +40,10 @@ class BASE_EXPORT TracedValue : public ConvertableToTraceFormat {

void BeginArray();

void BeginDictionary();

- virtual void AppendAsTraceFormat(std::string* out) const override;

+ void AppendAsTraceFormat(std::string* out) const override;

private:

- virtual ~TracedValue();

+ ~TracedValue() override;

DictionaryValue* GetCurrentDictionary();

ListValue* GetCurrentArray();

« no previous file with comments | « base/debug/stack_trace_posix.cc ('k') | base/debug/trace_event_impl.cc » ('j') | no next file with comments »